optimize ZString

Try · Try · commit b28899c6f492 · 2020-12-22T00:30:31.000+01:00
diff --git a/daedalus/ZString.cpp b/daedalus/ZString.cpp
@@ -9,6 +9,12 @@ static std::shared_ptr<std::string> emptyStr() {
   return v;
   }
 
+static std::shared_ptr<std::string> strFrmChr(std::string&& s) {
+  if(s.empty())
+    return emptyStr();
+  return std::make_shared<std::string>(std::move(s));
+  }
+
 static ZString strFromIntCache(uint8_t v){
   static ZString intCache[256];
   if(intCache[v].empty()){
@@ -30,11 +36,11 @@ ZString::ZString(const char* s) {
   }
 
 ZString::ZString(std::string&& s)
-  :val(std::make_shared<std::string>(std::move(s))){
+  :val(strFrmChr(std::move(s))){
   }
 
 ZString::ZString(std::unique_ptr<char[]>&& s)
-  :val(std::make_shared<std::string>(s.get())){
+  :val(strFrmChr(s.get())){
   }
 
 ZString::ZString(ZenLoad::ZenParser &input) {

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,12 @@ static std::shared_ptr<std::string> emptyStr() {`
`9`	`9`	`return v;`
`10`	`10`	`}`
`11`	`11`
	`12`	`+static std::shared_ptr<std::string> strFrmChr(std::string&& s) {`
	`13`	`+ if(s.empty())`
	`14`	`+ return emptyStr();`
	`15`	`+ return std::make_shared<std::string>(std::move(s));`
	`16`	`+ }`
	`17`	`+`
`12`	`18`	`static ZString strFromIntCache(uint8_t v){`
`13`	`19`	`static ZString intCache[256];`
`14`	`20`	`if(intCache[v].empty()){`
`@@ -30,11 +36,11 @@ ZString::ZString(const char* s) {`
`30`	`36`	`}`
`31`	`37`
`32`	`38`	`ZString::ZString(std::string&& s)`
`33`		`- :val(std::make_shared<std::string>(std::move(s))){`
	`39`	`+ :val(strFrmChr(std::move(s))){`
`34`	`40`	`}`
`35`	`41`
`36`	`42`	`ZString::ZString(std::unique_ptr<char[]>&& s)`
`37`		`- :val(std::make_shared<std::string>(s.get())){`
	`43`	`+ :val(strFrmChr(s.get())){`
`38`	`44`	`}`
`39`	`45`
`40`	`46`	`ZString::ZString(ZenLoad::ZenParser &input) {`