Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portal popup for upgrade when no plans available is blank #21992

Open
1 task done
cathysarisky opened this issue Jan 11, 2025 · 1 comment · May be fixed by #22512
Open
1 task done

Portal popup for upgrade when no plans available is blank #21992

cathysarisky opened this issue Jan 11, 2025 · 1 comment · May be fixed by #22512
Labels
bug [triage] something behaving unexpectedly

Comments

@cathysarisky
Copy link
Contributor

Issue Summary

My client has a post marked for paid members only. She doesn't currently have a paid plan. (While an edge case, this situation does happen sometimes.) Her theme is setting data-portal="account/plans" on a button. But clicking the button causes the portal popup to show only "Choose a plan" with nothing below it.

Desired behavior: Some text such as "Sorry, no paid plans are available" should appear.

Steps to Reproduce

Create a link with data-portal="account/plans" (or navigate to #/portal/account/plans ) and click it, while not having any paid plans.

Ghost Version

Ghost pro, 5.105.0

Node.js Version

ghost pro

How did you install Ghost?

ghost pro

Database type

MySQL 8

Browser & OS version

Windows/Chrome

Relevant log / error output

no console errors, just a failure to provide fallback text in the portal app!

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Jan 11, 2025
@sagzy sagzy added the P4 - Low label Jan 13, 2025
@sagzy
Copy link
Contributor

sagzy commented Jan 13, 2025

Thanks for raising the issue @cathysarisky, valid!

@sagzy sagzy removed the needs:triage [triage] this needs to be triaged by the Ghost team label Jan 13, 2025
@ErisDS ErisDS added bug [triage] something behaving unexpectedly and removed P4 - Low labels Mar 14, 2025
@im-adithya im-adithya linked a pull request Mar 16, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show informative message when no plans are available im-adithya/Ghost
3 participants
@ErisDS @sagzy @cathysarisky