Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ghost Admin] "What's New?" modal looks off in dark mode #21923

Open
1 task done
SteffoSpieler opened this issue Dec 19, 2024 · 3 comments · May be fixed by #22519
Open
1 task done

[Ghost Admin] "What's New?" modal looks off in dark mode #21923

SteffoSpieler opened this issue Dec 19, 2024 · 3 comments · May be fixed by #22519
Labels
needs:triage [triage] this needs to be triaged by the Ghost team

Comments

@SteffoSpieler
Copy link
Contributor

Issue Summary

The footer of the "What's new?" modal has a white background, which results in not being able to read the text of the "Turn on notifications" button.

grafik

Steps to Reproduce

  1. Open Ghost Admin.
  2. Enable dark mode.
  3. Open the "What’s new?" modal through the context menu on your profile picture.
  4. See the modal.

Ghost Version

5.105.0

Node.js Version

(Can't see that with docker)

How did you install Ghost?

Using a docker container on a debian 12 server.

Database type

MySQL 8

Browser & OS version

Firefox 133.0.3 (64-Bit) on Windows 11 Pro

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Dec 19, 2024
@CodeStarGM
Copy link

do you need any help with this?

@PraveenGokavarapu12
Copy link

Hey, I’d like to work on this issue. I’ve verified the problem and will submit a PR with a fix soon!

@SteffoSpieler
Copy link
Contributor Author

Image

Another interesting thing I just found: When the news list doesn't have a scrollbar (e.g. with a screen size like 1400x960), the bottom two corners don't have a radius (aka. they aren't round).

@im-adithya im-adithya linked a pull request Mar 17, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs:triage [triage] this needs to be triaged by the Ghost team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: whats new modal background color im-adithya/Ghost
3 participants
@SteffoSpieler @CodeStarGM @PraveenGokavarapu12