Skip to content

Commit daf1203

Browse files
Added error message field to the subscription form
fixes ENG-17
1 parent 539464a commit daf1203

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

assets/built/screen.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

assets/built/screen.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

assets/css/screen.css

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,6 @@ a:hover {
238238
display: flex;
239239
align-items: center;
240240
position: relative;
241-
overflow: hidden;
242241
max-width: 560px;
243242
width: 100%;
244243
height: 56px;
@@ -365,6 +364,15 @@ button.gh-form-input {
365364
display: block;
366365
}
367366

367+
.gh-form [data-members-error] {
368+
position: absolute;
369+
top: 100%;
370+
margin-top: 10px;
371+
width: 100%;
372+
font-size: 1.4rem;
373+
line-height: 1.4;
374+
}
375+
368376
@media (max-width: 576px) {
369377
.gh-form {
370378
font-size: 1.6rem;
@@ -1023,7 +1031,6 @@ Search LOGO Login Subscribe
10231031
.gh-header-inner {
10241032
position: relative;
10251033
overflow: hidden;
1026-
padding-bottom: 1px;
10271034
}
10281035

10291036
/* 8.1. Magazine layout */
@@ -1390,6 +1397,7 @@ Search LOGO Login Subscribe
13901397
flex-direction: column;
13911398
align-items: center;
13921399
gap: 48px;
1400+
overflow: unset;
13931401
margin: auto;
13941402
max-width: 1020px;
13951403
text-align: center;

partials/email-subscription.hbs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@
55
{{> "icons/loader"}}
66
{{> "icons/checkmark"}}
77
</button>
8+
<p data-members-error></p>
89
</form>

0 commit comments

Comments
 (0)