A new extension for creating and managing multiple iframes.

[izum00]

A new extension for creating and managing multiple iframes.
From: #2310

[CubesterYT]

Hello, please stop closing and recreating PRs

Also please refrain from adding translations yourself in the PR. I see other edits but I can't check them out from my phone.

[izum00]

Hello, please stop closing and recreating PRs

Also please refrain from adding translations yourself in the PR. I see other edits but I can't check them out from my phone.

I'm sorry. These are my first pull request and I'm new to using Github.
Also, what do you mean by "I see other edits but I can't check them out from my phone"?

[izum00]

I’m still waiting for your reply.

[ScratchFakemon]

Imo it would be better to just add these features to the main iframe extension. I'm not a reviewer and these aren't official change requests, but I think you should at least look into how plausible it would be for the extension to support multiple iframes.

[izum00]

Imo it would be better to just add these features to the main iframe extension. I'm not a reviewer and these aren't official change requests, but I think you should at least look into how plausible it would be for the extension to support multiple iframes.

I also submitted a pull request to add an ID assignment feature for the iframe in the existing Iframe extension. My assumption was that projects already using the existing Iframe extension would leave the argument blank or use the extension’s default value, so I designed it so that if the ID argument was empty, the iframe would use a default ID of “iframe.” However, in practice, there is a high possibility that the argument fields of the blocks may not display properly - such as in "https://studio.penguinmod.com/#1781399388".
Therefore, adding only an argument to an existing extension is risky.
That pull request was submitted at #2310
and has since been closed.
This demonstrates that existing extensions cannot be easily replaced, and by releasing it as a new extension, I aimed to avoid such bugs.

[ScratchFakemon]

Imo it would be better to just add these features to the main iframe extension. I'm not a reviewer and these aren't official change requests, but I think you should at least look into how plausible it would be for the extension to support multiple iframes.

I also submitted a pull request to add an ID assignment feature for the iframe in the existing Iframe extension. My assumption was that projects already using the existing Iframe extension would leave the argument blank or use the extension’s default value, so I designed it so that if the ID argument was empty, the iframe would use a default ID of “iframe.” However, in practice, there is a high possibility that the argument fields of the blocks may not display properly - such as in "https://studio.penguinmod.com/#1781399388". Therefore, adding only an argument to an existing extension is risky. That pull request was submitted at #2310 and has since been closed. This demonstrates that existing extensions cannot be easily replaced, and by releasing it as a new extension, I aimed to avoid such bugs.

have two separate blocks: one with the id and one without. as stated by the documentation, arguments must never be added to existing blocks.

[izum00]

Imo it would be better to just add these features to the main iframe extension. I'm not a reviewer and these aren't official change requests, but I think you should at least look into how plausible it would be for the extension to support multiple iframes.

I also submitted a pull request to add an ID assignment feature for the iframe in the existing Iframe extension. My assumption was that projects already using the existing Iframe extension would leave the argument blank or use the extension’s default value, so I designed it so that if the ID argument was empty, the iframe would use a default ID of “iframe.” However, in practice, there is a high possibility that the argument fields of the blocks may not display properly - such as in "https://studio.penguinmod.com/#1781399388". Therefore, adding only an argument to an existing extension is risky. That pull request was submitted at #2310 and has since been closed. This demonstrates that existing extensions cannot be easily replaced, and by releasing it as a new extension, I aimed to avoid such bugs.

have two separate blocks: one with the id and one without. as stated by the documentation, arguments must never be added to existing blocks.

That's a good idea!!
I will fix it.

[izum00]

!format

[izum00]

I’m still waiting for your reply.

[Brackets-Coder]

I'm still waiting for your reply

Hello @izum00,
I know a lack of feedback across several weeks is generally unacceptable for customer support in the business world, but this is a volunteer-maintained repository. These past few weeks have been very quiet with very little activity; this repository usually has high activity in bursts. @CubesterYT is likely busy outside of Turbowarp; I'm sure he'll get to you when he can.

Also, what do you mean by "I see other edits but I can't check them out from my phone"?

@CubesterYT I think it would be in our best interest to answer this question as soon as we can. @izum00, I think he means that he was away from home during the time he reviewed your code but the other edits you created were not visible on a mobile device.

[CubesterYT]

Hello!
Yes, as Brackets said, I was not able to see other file edits or code because they aren't visible on my mobile device, and I can't check further since I'm either not home or busy.