Improve typing in transforms.jl #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

xukai92 opened this issue May 4, 2017 · 0 comments

Member

xukai92 commented May 4, 2017

Some link/invlink don't deal with typing in a good manner. There are two things to improve

Replace constants 1 and 0 using one(T) and zero(T) (Use generic type constants instead of manually written #215)
make sure the return values has at least a type of Real not Any

The text was updated successfully, but these errors were encountered:

xukai92 added a commit that referenced this issue


          Fix transfom typing (#232)

f8a2e11

xukai92 added a commit that referenced this issue


          Improve typing in transforms.jl (#232)

ce94f19

yebai closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment