Stop after FFmpeg auto-download failure#836
Merged
Tyrrrz merged 3 commits intoMay 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the application exit when the automatic FFmpeg download fails, aligning the “download failed” path with the existing behavior when FFmpeg is missing and the user chooses not to download it.
Changes:
- After showing an error dialog for FFmpeg auto-download failures, the app now attempts to shut down (with a process-exit fallback).
- Keeps the “missing FFmpeg + user declines download” and “download attempt fails” outcomes consistent (both exit).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tyrrrz
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes the app if the automatic FFmpeg download fails.
If FFmpeg is missing and the user chooses not to download it, the app already exits. This makes the failed-download case behave the same way instead of leaving the app open in a state where downloads will still fail.
Checked with
dotnet build YoutubeDownloader.slnx.