Skip to content

Commit d6f3783

Browse files
committed
fix: Make plugin.json prettier-stable after release-please bumps
release-please's JSON updater re-stringifies the file with JSON.stringify(obj, null, indent), which always expands arrays to multi-line. The inline "skills": ["./skills/"] in plugin.json was therefore reformatted to multi-line on every release, and the subsequent prettier:check failed because prettier collapsed it again. Switch the prettier parser to json-stringify for **/plugin.json (same parser prettier already uses for package.json), which keeps every array multi-line — matching what release-please produces. Reformat the four plugin.json files in source so the check passes today.
1 parent afd95cb commit d6f3783

5 files changed

Lines changed: 21 additions & 5 deletions

File tree

.prettierrc

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,13 @@
22
"trailingComma": "es5",
33
"tabWidth": 4,
44
"semi": false,
5-
"singleQuote": false
5+
"singleQuote": false,
6+
"overrides": [
7+
{
8+
"files": ["**/plugin.json"],
9+
"options": {
10+
"parser": "json-stringify"
11+
}
12+
}
13+
]
614
}

plugins/ui5-typescript-conversion/.github/plugin/plugin.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,7 @@
1717
"typescript",
1818
"conversion"
1919
],
20-
"skills": ["./skills/"]
20+
"skills": [
21+
"./skills/"
22+
]
2123
}

plugins/ui5-typescript-conversion/plugin.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,7 @@
1717
"typescript",
1818
"conversion"
1919
],
20-
"skills": ["./skills/"]
20+
"skills": [
21+
"./skills/"
22+
]
2123
}

plugins/ui5/.github/plugin/plugin.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,7 @@
1919
"development-guidelines",
2020
"best-practices"
2121
],
22-
"skills": ["./skills/"]
22+
"skills": [
23+
"./skills/"
24+
]
2325
}

plugins/ui5/plugin.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,7 @@
1919
"development-guidelines",
2020
"best-practices"
2121
],
22-
"skills": ["./skills/"]
22+
"skills": [
23+
"./skills/"
24+
]
2325
}

0 commit comments

Comments
 (0)