Skip to content

Commit 1f2ec42

Browse files
committed
fix: import from base and remove edge case overflow code
1 parent 498d3bf commit 1f2ec42

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

packages/fiori/src/ShellBarV2.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import type { ResizeObserverCallback } from "@ui5/webcomponents-base/dist/delega
1111
import { getScopedVarName } from "@ui5/webcomponents-base/dist/CustomElementsScopeUtils.js";
1212
import arraysAreEqual from "@ui5/webcomponents-base/dist/util/arraysAreEqual.js";
1313
import type I18nBundle from "@ui5/webcomponents-base/dist/i18nBundle.js";
14-
import { renderFinished } from "@ui5/webcomponents-base";
14+
import { renderFinished } from "@ui5/webcomponents-base/dist/Render.js";
1515
import throttle from "@ui5/webcomponents-base/dist/util/throttle.js";
1616

1717
import type { IButton } from "@ui5/webcomponents/dist/Button.js";

packages/fiori/src/shellbarv2/ShellBarOverflow.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,6 @@ class ShellBarV2Overflow {
9393
}
9494
}
9595

96-
// never hide just one item as overflow button also accounts for one item
97-
if (hiddenItemsIds.length === 1 && nextItemToHide) {
98-
hiddenItemsIds.push(nextItemToHide.id);
99-
}
100-
10196
return {
10297
hiddenItemsIds,
10398
showOverflowButton,

packages/fiori/src/shellbarv2/ShellBarSearch.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { isPhone } from "@ui5/webcomponents-base";
1+
import { isPhone } from "@ui5/webcomponents-base/dist/Device.js";
22
import type { IShellBarSearchField } from "../ShellBarV2.js";
33
import type { IShellBarSearchController } from "./IShellBarSearchController.js";
44

0 commit comments

Comments
 (0)