fix: Fixes overflow pool printing

Author: TwoTenPvP

MLAPI/Serialization/Pooled/BitReaderPool.cs

@@ -21,9 +21,12 @@ public static PooledBitReader GetReader(Stream stream)
         {
             if (readers.Count == 0)
             {
-                if (createdReaders == 254) if (LogHelper.CurrentLogLevel <= LogLevel.Normal) LogHelper.LogWarning("255 readers have been created. Did you forget to dispose?");
-                    else if (createdReaders < 255) createdReaders++;
-                
+                if (createdReaders == 254)
+                {
+                    if (LogHelper.CurrentLogLevel <= LogLevel.Normal) LogHelper.LogWarning("255 readers have been created. Did you forget to dispose?");
+                }
+                else if (createdReaders < 255) createdReaders++;
+
                 return new PooledBitReader(stream);
             }
 
@@ -43,4 +46,4 @@ public static void PutBackInPool(PooledBitReader reader)
             else if (LogHelper.CurrentLogLevel <= LogLevel.Developer) LogHelper.LogInfo("BitReaderPool already has 64 queued. Throwing to GC. Did you forget to dispose?");
         }
     }
-}
+}

MLAPI/Serialization/Pooled/BitStreamPool.cs

@@ -22,16 +22,19 @@ public static PooledBitStream GetStream()
             if (overflowStreams.Count > 0)
             {
                 if (LogHelper.CurrentLogLevel <= LogLevel.Developer) LogHelper.LogInfo("Retrieving PooledBitStream from overflow pool. Recent burst?");
-                WeakReference weakStream;
-                while (!(weakStream = overflowStreams.Dequeue()).IsAlive) ;
+                WeakReference weakStream = null;
+                while (overflowStreams.Count > 0 && ((weakStream = overflowStreams.Dequeue()) == null || !weakStream.IsAlive)) ;
                 if (weakStream.IsAlive) return (PooledBitStream)weakStream.Target;
             }
 
             if (streams.Count == 0)
             {
-                if (createdStreams == 254) if (LogHelper.CurrentLogLevel <= LogLevel.Normal) LogHelper.LogWarning("255 streams have been created. Did you forget to dispose?");
+                if (createdStreams == 254)
+                {
+                    if (LogHelper.CurrentLogLevel <= LogLevel.Normal) LogHelper.LogWarning("255 streams have been created. Did you forget to dispose?");
+                }
                 else if (createdStreams < 255) createdStreams++;
-                
+
                 return new PooledBitStream();
             }
 
@@ -63,4 +66,4 @@ public static void PutBackInPool(PooledBitStream stream)
             }
         }
     }
-}
+}

MLAPI/Serialization/Pooled/BitWriterPool.cs

@@ -21,15 +21,18 @@ public static PooledBitWriter GetWriter(Stream stream)
         {
             if (writers.Count == 0)
             {
-                if (createdWriters == 254) if (LogHelper.CurrentLogLevel <= LogLevel.Normal) LogHelper.LogWarning("255 writers have been created. Did you forget to dispose?");
-                    else if (createdWriters < 255) createdWriters++;
-                
+                if (createdWriters == 254)
+                {
+                    if (LogHelper.CurrentLogLevel <= LogLevel.Normal) LogHelper.LogWarning("255 writers have been created. Did you forget to dispose?");
+                }
+                else if (createdWriters < 255) createdWriters++;
+
                 return new PooledBitWriter(stream);
             }
 
             PooledBitWriter writer = writers.Dequeue();
             writer.SetStream(stream);
-            
+
             return writer;
         }
 
@@ -43,4 +46,4 @@ public static void PutBackInPool(PooledBitWriter writer)
             else if (LogHelper.CurrentLogLevel <= LogLevel.Developer) LogHelper.LogInfo("BitWriterPool already has 64 queued. Throwing to GC. Did you forget to dispose?");
         }
     }
-}
+}

MLAPI/Serialization/Pooled/PooledBitStream.cs

@@ -8,6 +8,11 @@ namespace MLAPI.Serialization.Pooled
     public sealed class PooledBitStream : BitStream, IDisposable
     {
         private bool isDisposed = false;
+
+        internal PooledBitStream()
+        {
+        }
+
         /// <summary>
         /// Gets a PooledBitStream from the static BitStreamPool
         /// </summary>
@@ -31,4 +36,4 @@ public static PooledBitStream Get()
             }
         }
     }
-}
+}

MLAPI/Serialization/Pooled/PooledBitWriter.cs

@@ -9,10 +9,9 @@ namespace MLAPI.Serialization.Pooled
     public sealed class PooledBitWriter : BitWriter, IDisposable
     {
         private bool isDisposed = false;
-        
+
         internal PooledBitWriter(Stream stream) : base(stream)
         {
-
         }
 
         /// <summary>
@@ -38,4 +37,4 @@ public void Dispose()
             }
         }
     }
-}
+}