Skip to content

Commit 5d8c8a6

Browse files
authored
Merge pull request #39 from VadimDez/feature/#36
Feature/#36
2 parents 9f1b1b0 + 32a9e6e commit 5d8c8a6

21 files changed

+128
-85
lines changed

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
# compiled output
44
/dist
55
/tmp
6-
/aot
76

87
# dependencies
98
/node_modules

CHANGELOG.md

+9
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
# Changelog
22

3+
## 1.0.0
4+
* [[#36](https://github.com/VadimDez/ngx-filter-pipe/issues/36)] - Changed name tp `ngx-filter-pipe`.
5+
* [[#38](https://github.com/VadimDez/ngx-filter-pipe/issues/38)] - Added UMD bundle.
6+
7+
### Breaking changes
8+
9+
* Module name was changed from `Ng2FilterPipeModule` to `FilterPipeModule`.
10+
* UMD bundle for `SYSTEMJS` was added. user `/dist/bundles/ngx-filter-pipe.umd.js` instead of `/dist/index.js`.
11+
312
## 0.1.10
413
* [[#31](https://github.com/VadimDez/ng2-filter-pipe/issues/31)] - How to filter by two variables of the same array.
514
* [[#4](https://github.com/VadimDez/ng2-filter-pipe/issues/4)] - Add $or operator.

README.md

+12-12
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
<h1 align="center">Angular2+ Filter Pipe</h1>
22

33
<p align="center">
4-
<a href="https://www.npmjs.com/package/ng2-filter-pipe">
5-
<img src="https://img.shields.io/npm/dm/ng2-filter-pipe.svg?style=flat" alt="downloads">
4+
<a href="https://www.npmjs.com/package/ngx-filter-pipe">
5+
<img src="https://img.shields.io/npm/dm/ngx-filter-pipe.svg?style=flat" alt="downloads">
66
</a>
77

8-
<a href="https://travis-ci.org/VadimDez/ng2-filter-pipe" alt="build">
9-
<img src="https://travis-ci.org/VadimDez/ng2-filter-pipe.svg?branch=master" height="18">
8+
<a href="https://travis-ci.org/VadimDez/ngx-filter-pipe" alt="build">
9+
<img src="https://travis-ci.org/VadimDez/ngx-filter-pipe.svg?branch=master" height="18">
1010
</a>
1111

12-
<a href="https://badge.fury.io/js/ng2-filter-pipe">
13-
<img src="https://badge.fury.io/js/ng2-filter-pipe.svg" alt="npm version" height="18">
12+
<a href="https://badge.fury.io/js/ngx-filter-pipe">
13+
<img src="https://badge.fury.io/js/ngx-filter-pipe.svg" alt="npm version" height="18">
1414
</a>
1515

16-
<a href="https://david-dm.org/vadimdez/ng2-filter-pipe" title="dependencies status">
17-
<img src="https://david-dm.org/vadimdez/ng2-filter-pipe.svg" height="18">
16+
<a href="https://david-dm.org/vadimdez/ngx-filter-pipe" title="dependencies status">
17+
<img src="https://david-dm.org/vadimdez/ngx-filter-pipe.svg" height="18">
1818
</a>
1919
</p>
2020

@@ -28,17 +28,17 @@ Angular 2+ pipeline for filtering arrays.
2828

2929
### Demo Page
3030

31-
[https://vadimdez.github.io/ng2-filter-pipe/](https://vadimdez.github.io/ng2-filter-pipe/)
31+
[https://vadimdez.github.io/ngx-filter-pipe/](https://vadimdez.github.io/ngx-filter-pipe/)
3232

3333
## Install
3434

3535
```
36-
npm install ng2-filter-pipe --save
36+
npm install ngx-filter-pipe --save
3737
```
3838

3939
## Usage
4040

41-
In case you're using ```systemjs``` - see configuration [here](https://github.com/VadimDez/ng2-filter-pipe/blob/master/SYSTEMJS.md).
41+
In case you're using ```systemjs``` - see configuration [here](https://github.com/VadimDez/ngx-filter-pipe/blob/master/SYSTEMJS.md).
4242

4343
Import `Ng2FilterPipeModule` to your module
4444

@@ -47,7 +47,7 @@ import { NgModule } from '@angular/core';
4747
import { BrowserModule } from '@angular/platform-browser';
4848
import { AppComponent } from './app';
4949

50-
import { Ng2FilterPipeModule } from 'ng2-filter-pipe';
50+
import { Ng2FilterPipeModule } from 'ngx-filter-pipe';
5151

5252
@NgModule({
5353
imports: [BrowserModule, Ng2FilterPipeModule],

SYSTEMJS.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Append to `map`
77
```js
88
var map = {
99
...
10-
'ng2-filter-pipe': 'node_modules/ng2-filter-pipe'
10+
'ngx-filter-pipe': 'node_modules/ngx-filter-pipe'
1111
}
1212
```
1313

@@ -16,6 +16,6 @@ and then add to `packages`
1616
```js
1717
var packages = {
1818
...
19-
'ng2-filter-pipe': { main: 'dist/index.js' }
19+
'ngx-filter-pipe': { main: 'dist/bundles/ngx-filter-pipe.umd.js' }
2020
}
2121
````

examples/ng-cli/src/app/app.component.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div mdl class="mdl-layout mdl-js-layout mdl-layout--fixed-header">
22
<header class="mdl-layout__header mdl-layout--no-drawer-button">
33
<div class="mdl-layout__header-row">
4-
<span class="mdl-layout-title">ng2-filter-pipe</span>
4+
<span class="mdl-layout-title">ngx-filter-pipe</span>
55
</div>
66
</header>
77
<main class="mdl-layout__content">
@@ -305,9 +305,9 @@ <h5>After filtering</h5>
305305

306306
<footer class="mdl-mini-footer">
307307
<div class="mdl-mini-footer__left-section">
308-
<div class="mdl-logo">ng2-filter-pipe</div>
308+
<div class="mdl-logo">ngx-filter-pipe</div>
309309
<ul class="mdl-mini-footer__link-list">
310-
<li><a href="https://github.com/VadimDez/ng2-filter-pipe">Github</a></li>
310+
<li><a href="https://github.com/VadimDez/ngx-filter-pipe">Github</a></li>
311311
<li><a href="https://github.com/VadimDez">Vadym Yatsyuk</a></li>
312312
</ul>
313313
</div>

examples/ng-cli/src/app/app.module.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ import { HttpModule } from '@angular/http';
55

66
import { AppComponent } from './app.component';
77
// import { Ng2FilterPipeModule } from 'ng2-filter-pipe';
8-
import { Ng2FilterPipeModule } from './shared/ng2-filter.module';
8+
import { FilterPipeModule } from './shared/ngx-filter.module';
99

1010
@NgModule({
1111
imports: [
1212
BrowserModule,
1313
FormsModule,
1414
HttpModule,
15-
Ng2FilterPipeModule
15+
FilterPipeModule
1616
],
1717
declarations: [
1818
AppComponent,

examples/ng-cli/src/app/shared/ng2-filter.module.ts

-12
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
/**
2+
* Created by vadimdez on 28/11/2016.
3+
*/
4+
import { NgModule } from '@angular/core';
5+
import { FilterPipe } from './ngx-filter.pipe';
6+
7+
@NgModule({
8+
declarations: [FilterPipe],
9+
exports: [FilterPipe]
10+
})
11+
12+
export class FilterPipeModule {}

src/ng2-filter.pipe.spec.ts examples/ng-cli/src/app/shared/ngx-filter.pipe.spec.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
/* tslint:disable:no-unused-variable */
22

3-
import { Ng2FilterPipe } from './ng2-filter.pipe';
3+
import { FilterPipe } from './ngx-filter.pipe';
44

5-
describe('Pipe: Ng2FilterPipe', () => {
6-
let pipe: Ng2FilterPipe;
5+
describe('Pipe: FilterPipe', () => {
6+
let pipe: FilterPipe;
77

88
beforeEach(() => {
9-
pipe = new Ng2FilterPipe();
9+
pipe = new FilterPipe();
1010
});
1111

1212
it('create an instance', () => {

examples/ng-cli/src/app/shared/ng2-filter.pipe.ts examples/ng-cli/src/app/shared/ngx-filter.pipe.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { Pipe, Injectable } from '@angular/core';
99
})
1010

1111
@Injectable()
12-
export class Ng2FilterPipe {
12+
export class FilterPipe {
1313

1414
private filterByString(filter) {
1515
if (filter) {

examples/ng-cli/src/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33
<head>
44
<meta charset="utf-8">
5-
<title>NgCli</title>
5+
<title>ngx-filter-pipe</title>
66
<base href="/">
77

88
<meta name="viewport" content="width=device-width, initial-scale=1">

index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
22
* Created by vadimdez on 28/11/2016.
33
*/
4-
export * from './src/ng2-filter.module';
5-
export * from './src/ng2-filter.pipe';
4+
export * from './src/ngx-filter.module';
5+
export * from './src/ngx-filter.pipe';

package.json

+15-15
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,29 @@
11
{
2-
"name": "ng2-filter-pipe",
3-
"version": "0.1.10",
2+
"name": "ngx-filter-pipe",
3+
"version": "1.0.0",
44
"author": "Vadym Yatsyuk <[email protected]>",
55
"license": "MIT",
6-
"angular-cli": {},
76
"scripts": {
87
"start": "ng server",
9-
"typings": "typings install",
108
"lint": "tslint \"src/**/*.ts\"",
119
"test": "ng test --watch=false",
1210
"pree2e": "webdriver-manager update",
1311
"e2e": "protractor",
14-
"minify": "uglifyjs ./dist/app/shared/ng2-filter.pipe.js --compress --mangle --output ./ng2-filter.pipe.min.js --source-map ./ng2-filter.pipe.min.js.map",
15-
"build": "ngc -p tsconfig.json"
12+
"minify": "uglifyjs ./dist/app/shared/ngx-filter.pipe.js --compress --mangle --output ./ngx-filter.pipe.min.js --source-map ./ngx-filter.pipe.min.js.map",
13+
"build": "rimraf dist && tsc -p tsconfig-esm.json && mkdir ./dist/bundles && rollup -c rollup.config.js dist/index.js > dist/bundles/ngx-filter-pipe.umd.js && ngc -p tsconfig.json"
1614
},
1715
"repository": {
1816
"type": "git",
19-
"url": "git+https://[email protected]/VadimDez/ng2-filter-pipe.git"
17+
"url": "git+https://[email protected]/VadimDez/ngx-filter-pipe.git"
2018
},
2119
"bugs": {
22-
"url": "https://github.com/VadimDez/ng2-filter-pipe/issues"
20+
"url": "https://github.com/VadimDez/ngx-filter-pipe/issues"
2321
},
24-
"homepage": "https://github.com/VadimDez/ng2-filter-pipe#readme",
22+
"homepage": "https://github.com/VadimDez/ngx-filter-pipe#readme",
2523
"peerDependencies": {
2624
"@angular/core": ">=2.2.3"
2725
},
28-
"dependencies": {
29-
"typings": "^2.0.0"
30-
},
26+
"dependencies": {},
3127
"devDependencies": {
3228
"@angular/common": "^4.0.1",
3329
"@angular/compiler": "^4.0.1",
@@ -37,7 +33,6 @@
3733
"@angular/http": "^4.0.1",
3834
"@angular/platform-browser": "^4.0.1",
3935
"@angular/platform-browser-dynamic": "^4.0.1",
40-
"@types/core-js": "0.9.34",
4136
"@types/jasmine": "^2.5.47",
4237
"@types/node": "^6.0.51",
4338
"@types/phantom": "3.2.1",
@@ -57,6 +52,9 @@
5752
"material-design-lite": "^1.3.0",
5853
"protractor": "^5.1.1",
5954
"reflect-metadata": "^0.1.10",
55+
"rollup": "^0.43.0",
56+
"rollup-plugin-commonjs": "^8.0.2",
57+
"rollup-plugin-node-resolve": "^3.0.0",
6058
"rxjs": "^5.2.1-smooth",
6159
"systemjs": "^0.20.11",
6260
"ts-node": "^3.0.2",
@@ -65,14 +63,16 @@
6563
"uglifyjs": "^2.4.10",
6664
"zone.js": "^0.8.5"
6765
},
68-
"main": "dist/index.js",
69-
"typings": "dist/index.d.ts",
66+
"main": "dist/bundles/ngx-filter-pipe.umd.js",
67+
"module": "dist/index.js",
68+
"types": "dist/index.d.ts",
7069
"files": [
7170
"dist"
7271
],
7372
"keywords": [
7473
"angular",
7574
"angular2",
75+
"angular4",
7676
"filter",
7777
"pipe"
7878
]

rollup.config.js

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/**
2+
* Created by Vadym Yatsyuk on 22.06.17
3+
*/
4+
export default {
5+
format: 'umd',
6+
moduleName: 'ngx-filter-pipe',
7+
external: [
8+
'@angular/core'
9+
],
10+
onwarn: ( warning ) => {
11+
const skip_codes = [
12+
'THIS_IS_UNDEFINED',
13+
'MISSING_GLOBAL_NAME'
14+
];
15+
if (skip_codes.indexOf(warning.code) !== -1) {
16+
return;
17+
}
18+
console.error(warning);
19+
}
20+
};

src/ng2-filter.module.ts

-12
This file was deleted.

src/ngx-filter.module.ts

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
/**
2+
* Created by vadimdez on 28/11/2016.
3+
*/
4+
import { NgModule } from '@angular/core';
5+
import { FilterPipe } from './ngx-filter.pipe';
6+
7+
@NgModule({
8+
declarations: [FilterPipe],
9+
exports: [FilterPipe]
10+
})
11+
12+
export class FilterPipeModule {}

examples/ng-cli/src/app/shared/ng2-filter.pipe.spec.ts src/ngx-filter.pipe.spec.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
/* tslint:disable:no-unused-variable */
22

3-
import { Ng2FilterPipe } from './ng2-filter.pipe';
3+
import { FilterPipe } from './ngx-filter.pipe';
44

5-
describe('Pipe: Ng2FilterPipe', () => {
6-
let pipe: Ng2FilterPipe;
5+
describe('Pipe: FilterPipe', () => {
6+
let pipe: FilterPipe;
77

88
beforeEach(() => {
9-
pipe = new Ng2FilterPipe();
9+
pipe = new FilterPipe();
1010
});
1111

1212
it('create an instance', () => {

src/ng2-filter.pipe.ts src/ngx-filter.pipe.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { Pipe, Injectable } from '@angular/core';
99
})
1010

1111
@Injectable()
12-
export class Ng2FilterPipe {
12+
export class FilterPipe {
1313

1414
private filterByString(filter) {
1515
if (filter) {

tsconfig-esm.json

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
{
2+
"compilerOptions": {
3+
"noImplicitAny": false,
4+
"module": "es2015",
5+
"target": "es5",
6+
"emitDecoratorMetadata": true,
7+
"experimentalDecorators": true,
8+
"declaration": true,
9+
"sourceMap": true,
10+
"moduleResolution": "node",
11+
"rootDir": ".",
12+
"outDir": "./dist/",
13+
"lib": ["es2015", "dom"]
14+
},
15+
"files": [
16+
"index.ts"
17+
],
18+
"exclude": [
19+
"node_modules",
20+
"dist",
21+
"example",
22+
"examples",
23+
"typings",
24+
"aot"
25+
]
26+
}

0 commit comments

Comments
 (0)