verify: upload factory/ota bins as artifacts for test-flashing

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XpCz2RvuxV5uV8bFwCEpkL

Author: claude

.github/workflows/verify-rewire.yml

@@ -1,7 +1,8 @@
-# Verification-only build for the valar-core rewire branch. Compiles the rewired
+# Verification build for the valar-core rewire branch. Compiles the rewired
 # board configs (which pull valar-core + scheduling from valar-motion as remote
-# packages) on GitHub runners, which have the full network access needed for the
-# ESP-IDF toolchain download. No release/attach — this only proves it builds.
+# packages) on GitHub runners, and uploads the factory + OTA binaries as
+# downloadable artifacts so a board can be flashed for testing. This is NOT a
+# release — it attaches nothing to any release and does not touch main.
 name: Verify rewire build
 
 on:
@@ -15,15 +16,28 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        config:
-          - firmware/VAL3000/Ropener-VAL3000-rewired.yml
-          - firmware/VAL3100/Ropener-VAL3100-rewired.yml
+        include:
+          - config: firmware/VAL3000/Ropener-VAL3000-rewired.yml
+            asset: Ropener-VAL3000
+          - config: firmware/VAL3100/Ropener-VAL3100-rewired.yml
+            asset: Ropener-VAL3100
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
         with:
           python-version: '3.11'
       - name: Install ESPHome
         run: pip install esphome
-      - name: Compile ${{ matrix.config }}
+      - name: Compile ${{ matrix.asset }}
         run: esphome compile "${{ matrix.config }}"
+      - name: Collect binaries
+        run: |
+          mkdir -p dist
+          FACTORY=$(find . -path "*/.pioenvs/*/firmware.factory.bin" | head -1)
+          cp "$FACTORY" "dist/${{ matrix.asset }}.factory.bin"
+          OTA=$(find . -path "*/.pioenvs/*/firmware.ota.bin" | head -1)
+          cp "$OTA" "dist/${{ matrix.asset }}.ota.bin" 2>/dev/null || true
+      - uses: actions/upload-artifact@v4
+        with:
+          name: ${{ matrix.asset }}
+          path: dist/*.bin