Skip to content

Function signature table in edit function dialog #1385

Function signature table in edit function dialog

Function signature table in edit function dialog #1385

Triggered via push April 13, 2026 22:10
Status Failure
Total duration 6m 44s
Artifacts 1

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 6 warnings
this expression creates a reference which is immediately dereferenced by the compiler: rust/src/types.rs#L1252
error: this expression creates a reference which is immediately dereferenced by the compiler --> rust/src/types.rs:1252:45 | 1252 | let value_raw = Self::into_rust_raw(&self); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: rust/src/types.rs#L1240
error: this expression creates a reference which is immediately dereferenced by the compiler --> rust/src/types.rs:1240:45 | 1240 | let value_raw = Self::into_rust_raw(&self); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
this lifetime isn't used in the function definition: rust/src/types.rs#L971
error: this lifetime isn't used in the function definition --> rust/src/types.rs:971:9 | 971 | 'a, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes
this lifetime isn't used in the function definition: rust/src/types.rs#L920
error: this lifetime isn't used in the function definition --> rust/src/types.rs:920:21 | 920 | pub fn function<'a, T: Into<ReturnValue>>( | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes
this lifetime isn't used in the function definition: rust/src/types.rs#L495
error: this lifetime isn't used in the function definition --> rust/src/types.rs:495:9 | 495 | 'a, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes
this lifetime isn't used in the function definition: rust/src/types.rs#L443
error: this lifetime isn't used in the function definition --> rust/src/types.rs:443:21 | 443 | pub fn function<'a, T: Into<ReturnValue>>( | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes = note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::extra_unused_lifetimes)]`
useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`: rust/src/function.rs#L1100
error: useless conversion to the same type: `binaryninjacore_sys::BNValueLocation` --> rust/src/function.rs:1100:63 | 1100 | .for_each(|location| ValueLocation::free_rust_raw(location.into())); | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `types::ValueLocation`: rust/src/function.rs#L1086
error: useless conversion to the same type: `types::ValueLocation` --> rust/src/function.rs:1086:59 | 1086 | .map(|location| ValueLocation::into_rust_raw(&location.into())) | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`: rust/src/function.rs#L1077
error: useless conversion to the same type: `binaryninjacore_sys::BNValueLocation` --> rust/src/function.rs:1077:63 | 1077 | .for_each(|location| ValueLocation::free_rust_raw(location.into())); | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `types::ValueLocation`: rust/src/function.rs#L1063
error: useless conversion to the same type: `types::ValueLocation` --> rust/src/function.rs:1063:59 | 1063 | .map(|location| ValueLocation::into_rust_raw(&location.into())) | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
typos
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
cargo fmt
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
cargo clippy
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, clechasseur/rs-clippy-check@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
licensing
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/upload-artifact@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
licensing
Failed to restore:
licensing
New version for cargo-about available: 0.8.4

Artifacts

Produced during runtime
Name Size Digest
license
29.2 KB
sha256:f3056fc0c0a08bcd0cb6b72840a5f0e402bd487c86383a130290d5f05f5e156d