-
Notifications
You must be signed in to change notification settings - Fork 255
Closed
Labels
Component: UIIssue needs changes to the user interfaceIssue needs changes to the user interfaceEffort: TrivialIssue should take < 1 dayIssue should take < 1 dayImpact: LowIssue is a papercut or has a good, supported workaroundIssue is a papercut or has a good, supported workaroundUI: Cross ReferencesIssues with the Cross References widgetIssues with the Cross References widget
Milestone
Description
Binary Ninja Version
2.4.2846
Describe the bug
Cross reference icon changes depending on whether the cross references view is in table form or not.
To Reproduce
Steps to reproduce the behavior:
- Open a binary and select a function with cross references.
- In the cross references widget, right click and select "View as table"
Expected behavior
The icon should stay the same.
Screenshots
Version and Platform (required):
- Binary Ninja: Dev 2.4.2846
- OS: MacOS 11.4 Big Sur
Additional context
We should clearly define what the icon means. In default (non-table) form, the tail of the arrow is leaving a box, so one might think the box is the source of the cross reference, and the arrow points to the destination. However, due to rendering positioning in the widget, the head of the arrow is drawn next to the address of the cross reference, so it looks as if it's pointing toward the source.
Metadata
Metadata
Assignees
Labels
Component: UIIssue needs changes to the user interfaceIssue needs changes to the user interfaceEffort: TrivialIssue should take < 1 dayIssue should take < 1 dayImpact: LowIssue is a papercut or has a good, supported workaroundIssue is a papercut or has a good, supported workaroundUI: Cross ReferencesIssues with the Cross References widgetIssues with the Cross References widget