Skip to content

Xref widget always shows outgoing xref icon in table mode #2745

@lwerdna

Description

@lwerdna

Binary Ninja Version
2.4.2846

Describe the bug
Cross reference icon changes depending on whether the cross references view is in table form or not.

To Reproduce
Steps to reproduce the behavior:

  1. Open a binary and select a function with cross references.
  2. In the cross references widget, right click and select "View as table"

Expected behavior
The icon should stay the same.

Screenshots

xref_default

xref_table

Version and Platform (required):

  • Binary Ninja: Dev 2.4.2846
  • OS: MacOS 11.4 Big Sur

Additional context

We should clearly define what the icon means. In default (non-table) form, the tail of the arrow is leaving a box, so one might think the box is the source of the cross reference, and the arrow points to the destination. However, due to rendering positioning in the widget, the head of the arrow is drawn next to the address of the cross reference, so it looks as if it's pointing toward the source.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: UIIssue needs changes to the user interfaceEffort: TrivialIssue should take < 1 dayImpact: LowIssue is a papercut or has a good, supported workaroundUI: Cross ReferencesIssues with the Cross References widget

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions