Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bzlmod #17

Open
Vertexwahn opened this issue Aug 23, 2023 · 5 comments
Open

Add support for bzlmod #17

Vertexwahn opened this issue Aug 23, 2023 · 5 comments

Comments

@Vertexwahn
Copy link
Owner

Add support for bzlmod

@Wito-1
Copy link

Wito-1 commented Jan 24, 2024

Hello @Vertexwahn, this is a great repository.

I've taken this repo made some modifications to do a few things:

  1. upgrade to bzlmod
  2. download the qt libs using aqt
  3. modified the QtToolchainInfo / gen_* rules to be able to run in a sandbox environment (no local tags)

Are you accepting contributions?

@Vertexwahn
Copy link
Owner Author

@Wito-1
Yes, I definitely accept contributions!
What you describe sounds perfect!
For me, it is also not so important to keep the old traditional WORKSPACE approach - if this does not work anymore - no problem - we can delete it. Maybe I can do a last release that people can reference for using those rules without Bzlmod, before we delete this approach.

@Sayter99
Copy link

Sayter99 commented Jun 2, 2024

Hi @Vertexwahn, I came across this issue and started trying to migrate rules_qt6 to use bzlmod (my attempt). However, I found a weird thing that the compilation time increased a lot after migration.

Here's a test repository. By building //qwt with bzlmod, it takes ~3 mins, but only ~1 min using WORKSPACE approach.

Noted that it only happens on Windows, (linux behaves the same), so I guess long paths might play a role here, but have no idea how to confirm this assumption. Any thoughts/ideas?

@Vertexwahn
Copy link
Owner Author

@Sayter99 I have no clue. Maybe you repost this in the bzlmod channel of Bazel on Slack

@Sayter99
Copy link

Sayter99 commented Jun 4, 2024

good idea, I've posted one https://bazelbuild.slack.com/archives/C014RARENH0/p1717470840590809, FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants