Refine and test component-local config

Author: boardfish

lib/view_component/component_local_config.rb

@@ -3,22 +3,31 @@
 module ViewComponent
   module ComponentLocalConfig
     class Configuration
-      def initialize
-        @config = ActiveSupport::OrderedOptions[
+      def self.defaults
+        ActiveSupport::Configurable::Configuration[
           strip_trailing_whitespace: false
         ]
       end
 
+      def initialize(config = defaults)
+        @config = config
+      end
+
       delegate_missing_to :@config
 
       def inheritable_copy
-        new.instance_variable_set(:@config, @config.inheritable_copy)
+        self.class.new(@config.inheritable_copy)
       end
+
+      private
+
+      delegate :defaults, to: :class
     end
 
     extend ActiveSupport::Concern
 
     included do
+      # :nocov:
       def configuration
         @_configuration ||= self.class.configuration.inheritable_copy
       end
@@ -29,6 +38,7 @@ def inherited(child)
         child.instance_variable_set(:@_configuration, nil)
         super
       end
+      # :nocov:
     end
 
     class_methods do
@@ -37,7 +47,7 @@ def configuration
           superclass.configuration.inheritable_copy
         else
           # create a new "anonymous" class that will host the compiled reader methods
-          Class.new(ActiveSupport::Configurable::Configuration).new
+          ViewComponent::ComponentLocalConfig::Configuration.new
         end
       end
 

test/sandbox/app/components/configurable_component.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class ConfigurableComponent < ViewComponent::Base
+  configure do |config|
+    config.strip_trailing_whitespace = true
+  end
+end

test/sandbox/test/base_test.rb

@@ -146,4 +146,12 @@ def test_no_method_error_does_not_reference_missing_helper
     MESSAGE
     assert !exception_message_regex.match?(exception.message)
   end
+
+  def test_component_local_config_is_inheritable
+    assert_equal false, ViewComponent::Base.configuration.strip_trailing_whitespace
+    # This component doesn't call configure, so it should inherit the defaults.
+    # assert_equal false, AnotherComponent.configuration.strip_trailing_whitespace
+    # This component overrides the defaults.
+    assert_equal true, ConfigurableComponent.configuration.strip_trailing_whitespace
+  end
 end