Skip to content

Commit e94c1ed

Browse files
authored
remove JS and CSS docs as they proved difficult to maintain (#2194)
* remove JS and CSS docs as they proved difficult to maintain * fix CI * use concurrent-ruby for 6.1 support * use concurrent-ruby that works * force 1.3.4 * Update docs/CHANGELOG.md * Update docs/CHANGELOG.md
1 parent eba4c14 commit e94c1ed

File tree

5 files changed

+8
-172
lines changed

5 files changed

+8
-172
lines changed

Gemfile.lock

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ PATH
33
specs:
44
view_component (3.21.0)
55
activesupport (>= 5.2.0, < 8.1)
6-
concurrent-ruby (~> 1.0)
6+
concurrent-ruby (= 1.3.4)
77
method_source (~> 1.0)
88

99
GEM

docs/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ nav_order: 5
1010

1111
## main
1212

13+
* Remove JS and CSS docs as they proved difficult to maintain and lacked consensus.
14+
15+
*Joel Hawksley*
16+
1317
* Do not prefix release tags with `v`, per recommendation from @bkuhlmann.
1418

1519
*Joel Hawksley*

docs/guide/javascript_and_css.md

-168
This file was deleted.

test/sandbox/test/rendering_test.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ def test_render_inline_allocations
1616
MyComponent.ensure_compiled
1717

1818
allocations = (Rails.version.to_f >= 8.0) ?
19-
{"3.5.0" => 117, "3.4.1" => 117, "3.3.6" => 129} :
20-
{"3.3.6" => 120, "3.3.0" => 120, "3.2.6" => 118, "3.1.6" => 118, "3.0.7" => 127}
19+
{"3.5.0" => 117, "3.4.1" => 117, "3.3.7" => 129} :
20+
{"3.3.7" => 120, "3.3.0" => 120, "3.2.6" => 118, "3.1.6" => 118, "3.0.7" => 127}
2121

2222
assert_allocations(**allocations) do
2323
render_inline(MyComponent.new)

view_component.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
3131

3232
spec.add_runtime_dependency "activesupport", [">= 5.2.0", "< 8.1"]
3333
spec.add_runtime_dependency "method_source", "~> 1.0"
34-
spec.add_runtime_dependency "concurrent-ruby", "~> 1.0"
34+
spec.add_runtime_dependency "concurrent-ruby", "1.3.4" # lock version that supports Rails 6.1
3535
spec.add_development_dependency "allocation_stats", "~> 0.1.5"
3636
spec.add_development_dependency "appraisal", "~> 2.4"
3737
spec.add_development_dependency "benchmark-ips", "~> 2.13.0"

0 commit comments

Comments
 (0)