From ed18934db5afcf3480898db90ba73f829201f6ee Mon Sep 17 00:00:00 2001 From: Joel Hawksley Date: Tue, 13 May 2025 13:44:56 -0600 Subject: [PATCH 1/4] fix ci --- view_component.gemspec | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/view_component.gemspec b/view_component.gemspec index 811d270e3..218531139 100644 --- a/view_component.gemspec +++ b/view_component.gemspec @@ -64,4 +64,8 @@ Gem::Specification.new do |spec| if RUBY_VERSION >= "3.3" spec.add_development_dependency "propshaft", "~> 1" end + + if RUBY_VERSION >= "3.5" + spec.add_development_dependency "cgi" + end end From 9075aa5e2981c869d4e4016b4fe10bb684b4a534 Mon Sep 17 00:00:00 2001 From: Joel Hawksley Date: Tue, 13 May 2025 14:33:57 -0600 Subject: [PATCH 2/4] that didn't work --- view_component.gemspec | 4 ---- 1 file changed, 4 deletions(-) diff --git a/view_component.gemspec b/view_component.gemspec index 218531139..811d270e3 100644 --- a/view_component.gemspec +++ b/view_component.gemspec @@ -64,8 +64,4 @@ Gem::Specification.new do |spec| if RUBY_VERSION >= "3.3" spec.add_development_dependency "propshaft", "~> 1" end - - if RUBY_VERSION >= "3.5" - spec.add_development_dependency "cgi" - end end From 3fd60ca2b3fc03e994edc24396456d7f760a1ecb Mon Sep 17 00:00:00 2001 From: Joel Hawksley Date: Tue, 13 May 2025 15:46:57 -0600 Subject: [PATCH 3/4] try this --- Rakefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Rakefile b/Rakefile index bb04d1133..a5181eb9a 100644 --- a/Rakefile +++ b/Rakefile @@ -4,6 +4,7 @@ require "bundler/gem_tasks" require "rake/testtask" require "yard" require "yard/mattr_accessor_handler" +require "cgi/cookie" Rake::TestTask.new(:test) do |t| t.libs << "test" From f58e292b940cfca5cb6016f7323546c85eef1d2e Mon Sep 17 00:00:00 2001 From: Joel Hawksley Date: Tue, 13 May 2025 15:49:15 -0600 Subject: [PATCH 4/4] or this --- Gemfile.lock | 2 ++ view_component.gemspec | 1 + 2 files changed, 3 insertions(+) diff --git a/Gemfile.lock b/Gemfile.lock index cb826fcd6..e9666d86c 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -109,6 +109,7 @@ GEM rack-test (>= 0.6.3) regexp_parser (>= 1.5, < 3.0) xpath (~> 3.2) + cgi (0.4.2) concurrent-ruby (1.3.5) connection_pool (2.5.3) crass (1.0.6) @@ -392,6 +393,7 @@ DEPENDENCIES better_html bundler (~> 2) capybara (~> 3) + cgi cuprite erb_lint haml (~> 6) diff --git a/view_component.gemspec b/view_component.gemspec index 811d270e3..5efa55d49 100644 --- a/view_component.gemspec +++ b/view_component.gemspec @@ -63,5 +63,6 @@ Gem::Specification.new do |spec| if RUBY_VERSION >= "3.3" spec.add_development_dependency "propshaft", "~> 1" + spec.add_development_dependency "cgi" end end