fix: don't strip prefix is path is exactly "./" or ".\".

VirusTotal · Jan 18, 2025 · 4f4880f · 4f4880f
1 parent 45da681
commit 4f4880f
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 13 deletions.
diff --git a/cli/src/tests/mod.rs b/cli/src/tests/mod.rs
@@ -293,4 +293,23 @@ fn cli_issue_280() {
         .arg(".")
         .assert()
         .success();
+
+    // Handle special case of just ./ for path argument.
+    Command::cargo_bin("yr")
+        .unwrap()
+        .arg("scan")
+        .arg("src/tests/testdata/foo.yar")
+        .arg("./")
+        .assert()
+        .success();
+
+    // Handle special case of just .\ for path argument.
+    #[cfg(target_os = "windows")]
+    Command::cargo_bin("yr")
+        .unwrap()
+        .arg("scan")
+        .arg("src/tests/testdata/foo.yar")
+        .arg(r#".\"#)
+        .assert()
+        .success();
 }
diff --git a/cli/src/walk.rs b/cli/src/walk.rs
@@ -199,21 +199,19 @@ impl<'a> Walker<'a> {
         F: FnMut(&Path) -> anyhow::Result<()>,
         E: FnMut(anyhow::Error) -> anyhow::Result<()>,
     {
-        // Strip the ./ prefix (.\ in Windows), if present. This is a
-        // workaround for a bug in globwalk that causes a panic.
+        // Strip the ./ prefix (.\ in Windows), if present. Except for ".",
+        // "./" and ".\". This is a workaround for a bug in globwalk that
+        // causes a panic.
         // https://github.com/VirusTotal/yara-x/issues/280
         // https://github.com/Gilnaa/globwalk/issues/28
-        //
-        // Only perform the strip if the path is not exactly "." - this allows
-        // users to run "yr scan rules.yara ." to scan all the files in the
-        // current directory.
-        let path = if self.path.as_os_str().ne(".") {
-            #[cfg(not(target_os = "windows"))]
-            let path = self.path.strip_prefix("./").unwrap_or(self.path);
-
-            #[cfg(target_os = "windows")]
-            let path = self.path.strip_prefix(r#".\"#).unwrap_or(self.path);
-            path
+        let path = if self.path.as_os_str().len() > 2 {
+            self.path
+                .strip_prefix(if cfg!(target_os = "windows") {
+                    r#".\"#
+                } else {
+                    "./"
+                })
+                .unwrap_or(self.path)
         } else {
             self.path
         };