Skip to content

Commit 338ab35

Browse files
authored
ZF FROST Book text proof-read/review (ZcashFoundation#415)
* Replace "Distribtuted" with "Distributed" * rephrase to first person plural. The performance section actually refers to some individual that is not mentioned as author of the section and it's confusing who is alluded
1 parent ad636e8 commit 338ab35

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

book/src/frost.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ distribute each share to their respective participants.
3838

3939
[Learn how to do Trusted Dealer Generation with the ZF FROST library](tutorial.md#generating-key-shares-with-a-trusted-dealer).
4040

41-
### Distribtuted Key Generation
41+
### Distributed Key Generation
4242

4343
A two-round protocol after which each participant will have their share of the
4444
secret, without the secret being ever present in its entirety in any

book/src/tutorial/dkg.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ channel](https://frost.zfnd.org/terminology.html#peer-to-peer-channel). Note
77
that the first dashed line requires a [**broadcast
88
channel**](https://frost.zfnd.org/terminology.html#broadcast-channel)
99

10-
![Diagram of Distribtuted Key Generation, illustrating what is explained in the text](dkg/dkg.png)
10+
![Diagram of Distributed Key Generation, illustrating what is explained in the text](dkg/dkg.png)
1111

1212
## Part 1
1313

performance.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ FROST is a threshold Schnorr signature scheme
77
[invented](https://eprint.iacr.org/2020/852) by Chelsea Komlo (researcher at the
88
Zcash Foundation) and Ian Goldberg, and in the process of becoming an [IETF
99
RFC](https://datatracker.ietf.org/doc/draft-irtf-cfrg-frost/). Threshold
10-
signatures allows a private key being split into shares given to multiple
10+
signatures allow a private key being split into shares given to multiple
1111
participants, allowing a subgroup of them (e.g. 3 out of 5, or whatever
1212
threshold specified at key generation) to generate a signature that can be
1313
verified by the group public key, as if it were signed by the original unsplit
@@ -26,8 +26,8 @@ When we presented FROST at Zcon 3, we were asked how FROST performed in larger
2626
settings, such as a 667-of-1000 signers. (This is motivated by a mechanism
2727
proposed by Christopher Goes for [bridging Zcash with other ecosystems using
2828
FROST](https://forum.zcashcommunity.com/t/proposed-architecture-for-a-zcash-namada-ibc-ecosystem-ethereum-ecosystem-non-custodial-bridge-using-frost-multisignatures/42749).)
29-
We set out to benchmark our Rust implementation, and I was a bit surprised about
30-
one particular step, “Aggregate”.
29+
We set out to benchmark our Rust implementation, and were a bit surprised about
30+
one particular step: “Aggregate”.
3131

3232
The FROST scheme can be split into steps. The first one is Key Generation, which
3333
only needs to be done once, while the rest are carried out each time the group
@@ -52,7 +52,7 @@ number), but the Aggregate timings appeared too high, surpassing 400ms for the
5252
667-of-1000 case (which may not seem much but it’s unusual for a signing
5353
procedure).
5454

55-
I intended to investigate this but I didn’t even need to. Coincidentally, while
55+
We intended to investigate this but it was not necessary. Coincidentally, while
5656
the RFC was in the last call for feedback, Tim Ruffing [pointed
5757
out](https://mailarchive.ietf.org/arch/msg/cfrg/QQhyjvvcoaqLslaX3gWwABqHN-s/)
5858
that Aggregate can be sped up significantly. Originally, it was specified that

0 commit comments

Comments
 (0)