johnny/VIDSOL-211-advances-stable-but-integration erros

- removing noise
- adding scripts to debug locally

johnny/VIDSOL-211-advances

johnny/VIDSOL-211-revert camera/mic buttons changes

revert to later cause it breaks a lot of integration tests

johnny/VIDSOL-211-linter configurations and cleanups

johnny/VIDSOL-211-fixing infinite loop of retries on publish

johnny/VIDSOL-211-refinements and unit test

johnny/VIDSOL-211-removing opera

johnny/VIDSOL-211-Handle-permissions-if-user-disablesEnables-cameraMic

Author: johnny-quesada-developer

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -46,7 +46,6 @@ body:
         - Chrome
         - Firefox
         - Microsoft Edge
-        - Opera
         - Safari
         - Electron
 

.github/workflows/run-tests.yml

@@ -74,17 +74,6 @@ jobs:
           /opt/firefox/firefox --version
           echo "Firefox latest downloaded and installed"
 
-      - name: Install opera latest
-        run: |
-          sudo mkdir -p /etc/apt/keyrings
-          curl -fsSL https://deb.opera.com/archive.key | gpg --dearmor | sudo tee /etc/apt/keyrings/opera.gpg > /dev/null
-          echo "deb [signed-by=/etc/apt/keyrings/opera.gpg] https://deb.opera.com/opera-stable/ stable non-free" | \
-            sudo tee /etc/apt/sources.list.d/opera-stable.list > /dev/null
-          sudo apt-get update
-          sudo apt-get install opera-stable -y
-          echo "Check opera version"
-          /usr/bin/opera --version
-
       - name: Setup node
         if: steps.check-skip-ci.outputs.result == 'false'
         uses: actions/setup-node@v4

.github/workflows/update-screenshots.yml

@@ -72,16 +72,6 @@ jobs:
           echo "Check firefox version"
           /opt/firefox/firefox --version
           echo "Firefox latest downloaded and installed"
-      - name: install opera latest
-        if: steps.check-update-screenshots.outputs.result == 'true'
-        run: |
-          sudo add-apt-repository 'deb https://deb.opera.com/opera-stable/ stable non-free'
-          wget -qO- https://deb.opera.com/archive.key | sudo apt-key add -
-          sudo apt-get update
-          sudo apt-get install opera-stable -y
-          echo "Check opera version"
-          /usr/bin/opera --version
-          echo "Opera latest downloaded and installed"
 
       - name: Checkout
         if: steps.check-update-screenshots.outputs.result == 'true'

backend/eslint.config.mjs

@@ -2,12 +2,7 @@ import globals from 'globals';
 import baseConfig from '../eslint.config.mjs';
 
 export default [
-  {
-    ...baseConfig,
-
-    files: ['**/*.{ts,tsx,js,jsx}'],
-    languageOptions: {
-      globals: globals.node,
-    },
-  },
+  ...baseConfig,
+  { files: ['**/*.{ts,tsx,js,jsx}'], languageOptions: { globals: globals.node } },
+  { files: ['**/*.test.{ts,tsx,js,jsx}'], rules: { '@typescript-eslint/await-thenable': 'off' } },
 ];

backend/project.json

@@ -14,10 +14,7 @@
     },
     "start": {
       "executor": "nx:run-commands",
-      "options": {
-        "cwd": "backend",
-        "command": "node --import tsx index.ts"
-      }
+      "options": { "cwd": "backend", "command": "node --import tsx index.ts" }
     },
     "debug": {
       "executor": "nx:run-commands",
@@ -48,10 +45,14 @@
       "inputs": ["default", "^default", { "externalDependencies": ["jest", "ts-jest"] }]
     },
     "ts-check": {
+      "executor": "nx:run-commands",
+      "options": { "cwd": "backend", "command": "tsc -p tsconfig.json --pretty true --noEmit" }
+    },
+    "lint": {
       "executor": "nx:run-commands",
       "options": {
         "cwd": "backend",
-        "command": "tsc --noEmit -p tsconfig.json --pretty true"
+        "command": "eslint \"**/*.{ts,tsx,js,jsx}\" --report-unused-disable-directives --max-warnings 0"
       }
     }
   },

backend/routes/session.ts

@@ -7,23 +7,15 @@ import createGetOrCreateSession from './getOrCreateSession';
 const sessionRouter = Router();
 const videoService = createVideoService();
 const sessionService = getSessionStorageService();
-const getOrCreateSession = createGetOrCreateSession({
-  videoService,
-  sessionService,
-});
+const getOrCreateSession = createGetOrCreateSession({ videoService, sessionService });
 
 sessionRouter.get('/:room', async (req: Request<{ room: string }>, res: Response) => {
   try {
     const { room: roomName } = req.params;
     const sessionId = await getOrCreateSession(roomName);
     const data = videoService.generateToken(sessionId);
     const captionsId = await sessionService.getCaptionsId(roomName);
-    res.json({
-      sessionId,
-      token: data.token,
-      apiKey: data.apiKey,
-      captionsId,
-    });
+    res.json({ sessionId, token: data.token, apiKey: data.apiKey, captionsId });
   } catch (error: unknown) {
     const message = error instanceof Error ? error.message : error;
     res.status(500).send({ message });
@@ -36,15 +28,12 @@ sessionRouter.post('/:room/startArchive', async (req: Request<{ room: string }>,
     const sessionId = await sessionService.getSession(roomName);
     if (sessionId) {
       const archive = await videoService.startArchive(roomName, sessionId);
-      res.json({
-        archiveId: archive.id,
-        status: 200,
-      });
+      res.json({ archiveId: archive.id, status: 200 });
     } else {
       res.status(404).json({ message: 'Room not found' });
     }
   } catch (error: unknown) {
-    console.log(error);
+    console.error(error);
     const errorMessage = error instanceof Error ? error.message : 'Unknown error occurred';
     res.status(500).json({ message: errorMessage });
   }
@@ -57,10 +46,7 @@ sessionRouter.post(
       const { archiveId } = req.params;
       if (archiveId) {
         const responseArchiveId = await videoService.stopArchive(archiveId);
-        res.json({
-          archiveId: responseArchiveId,
-          status: 200,
-        });
+        res.json({ archiveId: responseArchiveId, status: 200 });
       }
     } catch (error: unknown) {
       res.status(500).send({ message: (error as Error).message ?? error });
@@ -74,10 +60,7 @@ sessionRouter.get('/:room/archives', async (req: Request<{ room: string }>, res:
     const sessionId = await sessionService.getSession(roomName);
     if (sessionId) {
       const archives = await videoService.listArchives(sessionId);
-      res.json({
-        archives,
-        status: 200,
-      });
+      res.json({ archives, status: 200 });
     } else {
       res.status(404).json({ message: 'Room not found' });
     }
@@ -109,10 +92,7 @@ sessionRouter.post(
       } else {
         // the captions were already enabled for this room
         const captionsId = await sessionService.getCaptionsId(roomName);
-        res.json({
-          captionsId,
-          status: 200,
-        });
+        res.json({ captionsId, status: 200 });
       }
     } catch (error: unknown) {
       const errorMessage = error instanceof Error ? error.message : 'Unknown error occurred';
@@ -148,15 +128,9 @@ sessionRouter.post(
       if (captionsUserCount === 0) {
         const disableResponse = await videoService.disableCaptions(captionsId);
         await sessionService.setCaptionsId(roomName, '');
-        res.json({
-          disableResponse,
-          status: 200,
-        });
+        res.json({ disableResponse, status: 200 });
       } else {
-        res.json({
-          disableResponse: 'Captions are still active for other users',
-          status: 200,
-        });
+        res.json({ disableResponse: 'Captions are still active for other users', status: 200 });
       }
     } catch (error: unknown) {
       const errorMessage = error instanceof Error ? error.message : 'Unknown error occurred';

backend/server.ts

@@ -34,7 +34,7 @@ app.get('/*', (_req: Request, res: Response) => {
 const startServer: () => Promise<Server> = () => {
   return new Promise((res) => {
     const server: Server = app.listen(port, () => {
-      console.log('Server listening on port', port);
+      console.info('Server listening on port', port);
       res(server);
     });
   });

backend/services/jiraFeedbackService.ts

@@ -33,29 +33,18 @@ class JiraFeedbackService implements FeedbackService {
   async reportIssue(data: FeedbackData): Promise<ReportIssueReturn | null> {
     const feedbackIssueData = {
       fields: {
-        project: {
-          key: this.jiraKey,
-        },
+        project: { key: this.jiraKey },
         summary: data.title,
         description: `Reported by: ${data.name}\n\n Issue description:\n${data.issue}`,
-        issuetype: {
-          name: 'Bug',
-        },
-        components: [
-          {
-            id: this.getComponentIdByOrigin(data.origin),
-          },
-        ],
+        issuetype: { name: 'Bug' },
+        components: [{ id: this.getComponentIdByOrigin(data.origin) }],
         [this.jiraEpicLink]: this.jiraEpicUrl,
       },
     };
 
     try {
-      const response = await axios.post(this.jiraApiUrl, feedbackIssueData, {
-        headers: {
-          'Content-Type': 'application/json',
-          Authorization: `Basic ${this.jiraToken}`,
-        },
+      const response = await axios.post<{ key: string }>(this.jiraApiUrl, feedbackIssueData, {
+        headers: { 'Content-Type': 'application/json', Authorization: `Basic ${this.jiraToken}` },
       });
 
       const ticketData: ReportIssueReturn = {
@@ -68,7 +57,7 @@ class JiraFeedbackService implements FeedbackService {
       }
       return await this.addAttachment(data.attachment, ticketData, response.data.key);
     } catch (error) {
-      console.log('Response Error:', error);
+      console.error('Response Error:', error);
       return null;
     }
   }
@@ -80,10 +69,7 @@ class JiraFeedbackService implements FeedbackService {
   ): Promise<ReportIssueReturn> {
     const fileBuffer = Buffer.from(attachment, 'base64');
     const formData = new FormData();
-    formData.append('file', fileBuffer, {
-      filename: 'screenshot.png',
-      contentType: 'image/png',
-    });
+    formData.append('file', fileBuffer, { filename: 'screenshot.png', contentType: 'image/png' });
 
     await axios.post(`${this.jiraApiUrl}${key}/attachments`, formData, {
       headers: {
@@ -94,10 +80,7 @@ class JiraFeedbackService implements FeedbackService {
       },
     });
 
-    return {
-      ...ticketData,
-      screenshotIncluded: true,
-    };
+    return { ...ticketData, screenshotIncluded: true };
   }
 
   private getComponentIdByOrigin(origin: FeedbackOrigin): string {

backend/storage/inMemorySessionStorage.ts

@@ -1,3 +1,5 @@
+// [TODO]: Fix require-await linting issue
+/* eslint-disable @typescript-eslint/require-await */
 import { SessionStorage } from './sessionStorage';
 
 interface SessionData {
@@ -14,11 +16,7 @@ class InMemorySessionStorage implements SessionStorage {
   }
 
   async setSession(roomName: string, sessionId: string): Promise<void> {
-    this.sessions[roomName] = {
-      sessionId,
-      captionsId: null,
-      captionsUserCount: 0,
-    };
+    this.sessions[roomName] = { sessionId, captionsId: null, captionsUserCount: 0 };
   }
 
   async setCaptionsId(roomName: string, captionsId: string): Promise<void> {

backend/storage/tests/inMemorySessionStorage.test.ts

@@ -89,7 +89,6 @@ describe('InMemorySessionStorage', () => {
       await storage.setSession(room, 'session123');
       await storage.incrementCaptionsUserCount(room);
       for (let i = 0; i < 5; i++) {
-        // eslint-disable-next-line no-await-in-loop
         const count = await storage.decrementCaptionsUserCount(room);
         expect(count).toBe(0);
       }