parse else/popmenu (#392)

* parse else/popmenu

* tweak docs

Author: dromer

CHANGELOG.md

@@ -10,7 +10,7 @@ Features:
 * Support `[route float]` for routing floats.
 * Support `trunc()` in `expr/expr~`.
 * Support `threshold~`.
-
+* Allow `else/popmenu` (converted to `[f ]`).
 
 0.16.2
 -----

docs/getting-started/patching.md

@@ -60,6 +60,7 @@ The following objects are supported:
 - Bang (bng)
 - Toggle (tgl)
 - Knob (knob, else/knob)
+- Popmenu (popmenu, else/popmenu)
 - Float atom (floatatom)
 
 An intermediate result GUI json is created containing these objects with their location, size and style. More information about [the IR](../reference/ir/heavy_gui_ir.md).

docs/reference/objects/supported.md

@@ -49,7 +49,6 @@ Here is a list of [unsupported Pd objects](unsupported.md).
 | div | |
 | exp | |
 | expr | except some functions. <sup>3</sup> Does not support symbol input. |
-| else/knob | converted to `[f ]` <sup>2</sup> |
 | f | |
 | float | |
 | floatatom | converted to `[f ]` <sup>2</sup> |
@@ -238,8 +237,12 @@ Objects ported from other PD externals
 
 | object | limitations |
 | --- | --- |
+| else/knob | converted to `[f ]` <sup>1</sup> |
+| else/popmenu | converted to `[f ]` <sup>1</sup> |
 | pdnam~ | only supports WaveNet models Nano, Feather, Lite, and Standard |
 
+1. Supports setting send/receive configuration, see [Getting Started](../../getting-started/patching.md#gui-objects)
+
 ## Supported Abstractions
 
 These are commonly used - or built in - abstractions that consist of compatible vanilla objects.

hvcc/interpreters/pd2gui/PdGUIParser.py

@@ -13,7 +13,7 @@
 from hvcc.types.GUI import (
     Size, Coords, Font, LabelShow, LabelPos, Label, Color, Canvas,
     Bang, Toggle, VRadio, HRadio, VSlider, HSlider, Knob,  Number, Float,
-    Comment, GUIObjects, Graph, GraphRoot
+    Comment, Popmenu, GUIObjects, Graph, GraphRoot
 )
 
 
@@ -181,6 +181,8 @@ def gui_from_canvas(
                             x = self.add_knob(line)
                         elif obj_type == "nbx":
                             x = self.add_number(line)
+                        elif obj_type == "popmenu" or obj_type == "else/popmenu":
+                            x = self.add_popmenu(line)
 
                     if x is not None:
                         objects.append(x)
@@ -655,3 +657,26 @@ def add_float(cls, line: list[str]) -> Optional[Float]:
             min=float(line[5]),
             max=float(line[6])
         )
+
+    @classmethod
+    def add_popmenu(cls, line: list[str]) -> Optional[Popmenu]:
+        param = cls.filter_params(line[11])
+        if param is None:
+            return None
+
+        return Popmenu(
+            position=Coords(
+                x=int(line[2]),
+                y=int(line[3])
+            ),
+            size=Size(
+                x=int(line[5]),
+                y=int(line[6])
+            ),
+            parameter=param,
+            font_height=int(line[7]),
+            no_select=line[10],
+            fg_color=Color(line[9]),
+            bg_color=Color(line[8]),
+            options=line[26:],
+        )

hvcc/interpreters/pd2hv/PdParser.py

@@ -563,15 +563,17 @@ def finalize_array(array: HeavyObject) -> None:
 
                         # add gui send/receive objects
                         arg_index = {
-                            "nbx":       (6, 7),
-                            "vsl":       (6, 7),
-                            "hsl":       (6, 7),
-                            "vradio":    (4, 5),
-                            "hradio":    (4, 5),
-                            "bng":       (4, 5),
-                            "tgl":       (2, 3),
-                            "knob":      (5, 6),
-                            "else/knob": (5, 6),
+                            "nbx":          (6, 7),
+                            "vsl":          (6, 7),
+                            "hsl":          (6, 7),
+                            "vradio":       (4, 5),
+                            "hradio":       (4, 5),
+                            "bng":          (4, 5),
+                            "tgl":          (2, 3),
+                            "knob":         (5, 6),
+                            "else/knob":    (5, 6),
+                            "popmenu":      (7, 6),
+                            "else/popmenu": (7, 6),
                         }
 
                         if obj_type in arg_index.keys():

hvcc/interpreters/pd2hv/libs/else/popmenu.pd

@@ -0,0 +1,6 @@
+#N canvas 0 149 210 157 10;
+#X obj 24 35 inlet;
+#X obj 24 57 float 0;
+#X obj 24 79 outlet;
+#X connect 0 0 1 0;
+#X connect 1 0 2 0;

hvcc/types/GUI.py

@@ -170,7 +170,16 @@ class Float(BaseParam):
     max: float
 
 
-GUIObjects = Union[Bang, Toggle, Radio, Slider, Knob, Number, Float, Comment, Canvas]
+class Popmenu(BaseParam):
+    type: Literal["popmenu"] = "popmenu"
+    font_height: int
+    no_select: str
+    fg_color: Color
+    bg_color: Color
+    options: list[str]
+
+
+GUIObjects = Union[Bang, Toggle, Radio, Slider, Knob, Number, Float, Comment, Canvas, Popmenu]
 
 
 class Theme(BaseModel):