Skip to content

Commit 04f0cf2

Browse files
committed
fix: resolved PR comments
Signed-off-by: Gaurav Goel <[email protected]>
1 parent 8a61f6f commit 04f0cf2

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

app/src/main/java/com/web3auth/app/MainActivity.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@ class MainActivity : AppCompatActivity(), AdapterView.OnItemClickListener {
134134
"loginConfig" to LoginConfigItem(
135135
"torus",
136136
typeOfLogin = TypeOfLogin.GOOGLE,
137-
name = ""
137+
name = "",
138+
clientId = ""
138139
)
139140
)
140141
)

core/src/main/java/com/web3auth/core/Web3Auth.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,14 @@ class Web3Auth(web3AuthOptions: Web3AuthOptions) {
4646
web3AuthOption.buildEnv.toString().lowercase()
4747
if (web3AuthOption.mfaSettings != null) initOptions["mfaSettings"] =
4848
gson.toJson(web3AuthOption.mfaSettings)
49+
if (params?.sessionTime != null) initOptions["sessionTime"] =
50+
params.sessionTime.toString()
4951

5052
val initParams = mutableMapOf(
5153
"loginProvider" to params?.loginProvider,
5254
"extraLoginOptions" to params?.extraLoginOptions,
5355
"redirectUrl" to if (params?.redirectUrl != null) params.redirectUrl.toString() else initOptions["redirectUrl"].toString(),
5456
"mfaLevel" to params?.mfaLevel,
55-
"sessionTime" to params?.sessionTime,
5657
"curve" to params?.curve,
5758
"dappShare" to params?.dappShare
5859
)

core/src/main/java/com/web3auth/core/types/LoginConfigItem.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ data class LoginConfigItem(
55
private var typeOfLogin: TypeOfLogin,
66
private var name: String? = null,
77
private var description: String? = null,
8-
private var clientId: String? = null,
8+
private var clientId: String,
99
private var verifierSubIdentifier: String? = null,
1010
private var logoHover: String? = null,
1111
private var logoLight: String? = null,

0 commit comments

Comments
 (0)