Fix subtyping for tables

Author: stevenfontanella

scripts/test/shared.py

@@ -387,9 +387,6 @@ def get_tests(test_dir, extensions=[], recursive=False):
     # Requires us to write our own floating point parser
     'const.wast',
 
-    # Unlinkable module accepted
-    'linking.wast',
-
     # Invalid module accepted
     'unreached-invalid.wast',
 
@@ -423,7 +420,6 @@ def get_tests(test_dir, extensions=[], recursive=False):
     'if.wast',      # Requires more precise unreachable validation
     'imports.wast',  # Requires fixing handling of mutation to imported globals
     'proposals/threads/imports.wast',  # Missing memory type validation on instantiation
-    'linking.wast',  # Incorrectly allows covariant subtyping for table imports
     'proposals/threads/memory.wast',  # Missing memory type validation on instantiation
     'annotations.wast',  # String annotations IDs should be allowed
     'instance.wast',  # Requires support for table default elements

src/ir/runtime-table.h

@@ -47,8 +47,8 @@ class RuntimeTable {
   // be imported with the definition of `other`
   virtual bool isSubType(const Table& other) {
     return tableDefinition.addressType == other.addressType &&
-           Type::isSubType(tableDefinition.type, other.type) &&
-           size() >= other.initial && tableDefinition.max <= other.max;
+           tableDefinition.type == other.type && size() >= other.initial &&
+           tableDefinition.max <= other.max;
   }
 
   const Table* getDefinition() const { return &tableDefinition; }

test/spec/imports.wast

@@ -10,14 +10,11 @@
   (func (export "func-i64->i64") (param i64) (result i64) (local.get 0))
   (global (export "global-i32") i32 (i32.const 55))
   (global (export "global-f32") f32 (f32.const 44))
-  ;;; FIXME: Exporting a mutable global is currently not supported. Make mutable
-  ;;; when support is added.
-  (global (export "global-mut-i64") i64 (i64.const 66))
+  (global (export "global-mut-i64") (mut i64) (i64.const 66))
   (table (export "table-10-inf") 10 funcref)
   (table (export "table-10-20") 10 20 funcref)
   (memory (export "memory-2-inf") 2)
-  ;; Multiple memories are not yet supported
-  ;; (memory (export "memory-2-4") 2 4)
+  (memory (export "memory-2-4") 2 4)
 )
 
 (register "test")