Skip to content

Conversation

@amirthfultehrani
Copy link

Dear @WilliamJudge94, may you be well!

Firstly, thank you for your excellent work on adding Python 3.13 support in your upstream PR #1778! For a business statistics class I am taking this semester, I wanted to experiment with ydata-profiling, but upon attempting installation, I ran into the ERROR: No matching distribution found for ydata-profiling ; so, having seen your develop branch, I was made happy.

Upon attempting to install directly from your branch (pip install git+....), the process failed with the error: ERROR: Package 'ydata-profiling' requires a different Python: 3.13.1 not in '<3.13,>=3.7.

It appeared that the package metadata in pyproject.toml still restricted the installation despite your code changes for 3.13 support being complete.

Thus, this PR of mine proposes a one-line change to pyproject.toml: making it go from requires-python = ">=3.7,<3.13" to requires-python = ">=3.7,<3.14". After applying this fix, I was able to successfully install your branch on my Python 3.13.1 environment.

As a result, I submit this directly to your branch in hopes of consolidating your Python 3.13 effort and hopefully making your main PR even easier for the upstream maintainers to merge.

Thank you again for all your great work, @WilliamJudge94. A great day to you!

@WilliamJudge94
Copy link
Owner

@amirthfultehrani, Thank you for bringing this to my attention and for the kind words! I’ve pushed the updates to my latest fork. I initially thought this was just a comment rather than a full PR, but the edit is now implemented in the fork. Closing this PR since the changes are already included.

@amirthfultehrani
Copy link
Author

Awesome, thank you very much for incorporating the fix @WilliamJudge94. I am glad I could help and I look forward to seeing your PR get merged upstream. Thank you again, @WilliamJudge94!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants