Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sniff for required function parameter #787

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Add sniff for required function parameter #787

wants to merge 1 commit into from

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Nov 12, 2024 •
edited
Loading

Fixes #756

  • Introduce new sniff: PluginCheck.CodeAnalysis.RequiredFunctionParameters
  • Add this rule to plugin-review.xml
  • Add unit test for the changes

@ernilambar ernilambar marked this pull request as ready for review November 12, 2024 10:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: chriscct7 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Nov 12, 2024
@ernilambar ernilambar added this to the 1.3.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidperezgar davidperezgar davidperezgar approved these changes

@swissspidy swissspidy Awaiting requested review from swissspidy

@chriscct7 chriscct7 Awaiting requested review from chriscct7

@frantorres frantorres Awaiting requested review from frantorres

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Restrict parse_str() without second argument
2 participants
@ernilambar @davidperezgar