syslog identifier is garbage memory/Startup banners are marked as alerts

[EXtremeExploit]

Select the version

25.0.0.X

Describe your issue

In journalctl and in ksystemlog, the identifiers for the xserver logs seem to be garbage memory and appear as alerts:

Altho the messages themselves do seem to appear correctly:

Steps to reproduce

1. Start the xserver
2. Check journalctl/ksystemlog for its identifiers
3. Observe (?

What did you expect?

For the logs to be displayed as info/debug/notice with their proper identifier so its easier to sort them,
Not sure if markers should be displayed in syslog but its fine i guess

Additional Information

Running from the AUR package xlibre-xserver
Arch Linux 6.19.6, systemd 259.5
If more info needed i can add it

Extra fields

• I have checked the existing issues
• I have read the Contributing Guidelines
• I'd like to work on this issue

[EXtremeExploit]

Looking into the source code of syslog, it seems that it uses the same pointer, meaning it doesnt copy the memory at all, so the ident memory address has to live for the whole duration of the program, which is not whats happening.
Instead, its a stack pointer, when the stack exits, the used memory just becomes something else/unused

One solution would be either to malloc the ident or to make it a static variable so its always valid (i dont know which one would be preferable)

Regardless of the change, it looks like this, which is a bit messy, and the ident is now user@1000.service:

But the identifier seems to be fine in journalctl:

My theory is the : that specifies the display messes up the parsing

[metux]

Indeed. Feel free to submit a PR :)

[EXtremeExploit]

Settings the ident to a nullpointer (to make openlog skip the identificator completely and use default) seems to fix all the issues, but the tiny problem is that we dont know which display the logs are from, if im doing a PR it would be for this case since imo its better to have stuff displayed properly rather than a mess with parsing

[EXtremeExploit]

The garbage memory problem got fixed, but the banners being marked as alerts remain