Skip to content

Commit ec590b3

Browse files
committed
remove unnecessary payment test
1 parent a36a8f0 commit ec590b3

File tree

2 files changed

+6
-27
lines changed

2 files changed

+6
-27
lines changed

packages/xrpl/test/integration/transactions/payment.test.ts

+6-14
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,15 @@ import {
77
teardownClient,
88
type XrplIntegrationTestContext,
99
} from '../setup'
10-
import {
11-
fetchAccountReserveFee,
12-
generateFundedWallet,
13-
testTransaction,
14-
} from '../utils'
10+
import { generateFundedWallet, testTransaction } from '../utils'
1511

1612
// how long before each test case times out
1713
const TIMEOUT = 20000
1814

1915
describe('Payment', function () {
2016
let testContext: XrplIntegrationTestContext
2117
let paymentTx: Payment
22-
let amount: string
23-
const DEFAULT_AMOUNT = '10000000'
18+
const AMOUNT = '10000000'
2419
// This wallet is used for DeliverMax related tests
2520
let senderWallet: Wallet
2621

@@ -30,17 +25,14 @@ describe('Payment', function () {
3025
paymentTx = {
3126
TransactionType: 'Payment',
3227
Account: senderWallet.classicAddress,
33-
Amount: amount,
28+
Amount: AMOUNT,
3429
Destination: 'rfkE1aSy9G8Upk4JssnwBxhEv5p4mn2KTy',
3530
}
3631
})
3732

3833
beforeAll(async () => {
3934
testContext = await setupClient(serverUrl)
4035
senderWallet = await generateFundedWallet(testContext.client)
41-
// Make sure the amount sent satisfies minimum reserve requirement to fund an account.
42-
amount =
43-
(await fetchAccountReserveFee(testContext.client)) ?? DEFAULT_AMOUNT
4436
})
4537
afterAll(async () => teardownClient(testContext))
4638

@@ -68,7 +60,7 @@ describe('Payment', function () {
6860
)
6961

7062
assert.equal(result.result.engine_result_code, 0)
71-
assert.equal((result.result.tx_json as Payment).Amount, amount)
63+
assert.equal((result.result.tx_json as Payment).Amount, AMOUNT)
7264
},
7365
TIMEOUT,
7466
)
@@ -88,7 +80,7 @@ describe('Payment', function () {
8880
)
8981

9082
assert.equal(result.result.engine_result_code, 0)
91-
assert.equal((result.result.tx_json as Payment).Amount, amount)
83+
assert.equal((result.result.tx_json as Payment).Amount, AMOUNT)
9284
},
9385
TIMEOUT,
9486
)
@@ -106,7 +98,7 @@ describe('Payment', function () {
10698
)
10799

108100
assert.equal(result.result.engine_result_code, 0)
109-
assert.equal((result.result.tx_json as Payment).Amount, amount)
101+
assert.equal((result.result.tx_json as Payment).Amount, AMOUNT)
110102
},
111103
TIMEOUT,
112104
)

packages/xrpl/test/integration/utils.ts

-13
Original file line numberDiff line numberDiff line change
@@ -445,16 +445,3 @@ export async function createAMMPool(client: Client): Promise<{
445445
asset2,
446446
}
447447
}
448-
449-
export async function fetchAccountReserveFee(
450-
client: Client,
451-
): Promise<string | null> {
452-
const response = await client.request({ command: 'server_state' })
453-
const fee = response.result.state.validated_ledger?.reserve_base
454-
455-
if (fee == null) {
456-
return null
457-
}
458-
459-
return new BigNumber(fee).dp(0, BigNumber.ROUND_CEIL).toString(10)
460-
}

0 commit comments

Comments
 (0)