Skip to content

Commit 51c5bdb

Browse files
committed
Moves RBAC resources to a dedicated base, so specs that don't
need rbac can be created and deleted faster. Specs might not use the kubernetes client, or mighte have sufficient access with the default service account such as in ephemeral test clusters.
1 parent 990f268 commit 51c5bdb

File tree

4 files changed

+15
-3
lines changed

4 files changed

+15
-3
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
apiVersion: kustomize.config.k8s.io/v1beta1
2+
kind: Kustomization
3+
bases:
4+
- ../rbac-readonly
5+
- ../kustomize
6+
patchesStrategicMerge:
7+
- specs-serviceaccount.yaml
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
apiVersion: apps/v1
2+
kind: Deployment
3+
metadata:
4+
name: specs
5+
spec:
6+
template:
7+
spec:
8+
serviceAccountName: assert

runtime-nodejs/kustomize/kustomization.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
apiVersion: kustomize.config.k8s.io/v1beta1
22
kind: Kustomization
3-
bases:
4-
- ../rbac-readonly
53
resources:
64
- scrapeable-deployment.yaml
75
# TODO if many tests reuse this base, how do we manage podmonitor?

runtime-nodejs/kustomize/scrapeable-deployment.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ spec:
1212
labels:
1313
kubernetes-assert: metrics
1414
spec:
15-
serviceAccountName: assert
1615
containers:
1716
- name: specs
1817
# We can't have a tag here because https://kubectl.docs.kubernetes.io/pages/reference/kustomize.html#images won't unset it, and Skaffold required no-tag URLs for build

0 commit comments

Comments
 (0)