Support non decreasing sorts in reactome pathway analysis

[Nelson-Gon]

Prerequisites

• Have you read Feedback and follow the guide?
  • make sure your are using the latest release version
  • read the documents
  • google your quesion/issue

Describe you issue

• Make a reproducible example (e.g. 1)
• your code should contain comments to describe the problem (e.g. what expected and actually happened?)

Hi, I have been exploring this package and once again stumbled on the strict decreasing only sort. Here is how to reproduce:

data("geneList", package="DOSE")
non_decreasing <-sort(geneList, decreasing=FALSE)
ReactomePA::gsePathway(non_decreasing, 
                pvalueCutoff = 0.2,
                pAdjustMethod = "BH", 
                verbose = FALSE)

The above will throw the following error:

Error in GSEA_internal(geneList = geneList, exponent = exponent, minGSSize = minGSSize, :
geneList should be a decreasing sorted vector...

This is related to YuLab-SMU/DOSE#58. I also see that in a comment, there is some suggestion that this was fixed but looking at the code in DOSE, isSorted still only allows for a decreasing sort.

This is also related to PR YuLab-SMU/DOSE#59 where I had attempted to fix this.

Thank you,

NelsonGon

Ask in right place

• for bugs or feature requests, post here (github issue)
• for questions, please post to Bioconductor or Biostars with tag ReactomePA