Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion 2: Abstract and Unify the Encrypt / Decrypt Functions for All HTTP Files #477

Closed
mpguerra opened this issue Feb 18, 2025 · 0 comments · Fixed by #495 · May be fixed by #496
Closed

Suggestion 2: Abstract and Unify the Encrypt / Decrypt Functions for All HTTP Files #477

mpguerra opened this issue Feb 18, 2025 · 0 comments · Fixed by #495 · May be fixed by #496

Comments

@mpguerra
Copy link
Contributor

Location

src/comms/http.rs#L117
src/comms/http.rs#L370
src/comms/http.rs#L276

Synopsis

The DKG component, the participant, and the coordinator each implement the same struct, HTTPComms, which includes an encryption and decryption function for messages received via the server.

Mitigation

Since the code is the same across the three implementations, we recommend unifying this code for better abstraction and improved error resilience.

@mpguerra mpguerra added this to the FROST Demo Audit milestone Feb 18, 2025
@mpguerra mpguerra moved this to Sprint Backlog in FROST Feb 18, 2025
@mpguerra mpguerra linked a pull request Feb 25, 2025 that will close this issue
@mpguerra mpguerra moved this from Sprint Backlog to Review/QA in FROST Feb 25, 2025
@mpguerra mpguerra linked a pull request Feb 25, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from Review/QA to Done in FROST Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
1 participant