Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: support negative heights #9025

Open
conradoplg opened this issue Nov 15, 2024 · 3 comments · May be fixed by #9316
Open

rpc: support negative heights #9025

conradoplg opened this issue Nov 15, 2024 · 3 comments · May be fixed by #9316
Assignees
@upbqdn
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage
Milestone
Zebra Ready for z...

Comments

@conradoplg
Copy link
Collaborator

Motivation

In a bunch of RPC calls like getblock, zcashd supports negative heights (where -1 is the last known valid block) but Zebra doesn't. It is a useful feature in particular for getting the latest block and seems easy to support.

Look which RPC calls support it in zcashd and add support to Zebra

Specifications

No response

Complex Code or Requirements

No response

Testing

No response

Related Work

No response
@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Nov 15, 2024
@github-project-automation github-project-automation bot moved this to New in Zebra Nov 15, 2024
@mpguerra mpguerra moved this from New to Sprint Backlog in Zebra Jan 22, 2025
@mpguerra mpguerra moved this from Sprint Backlog to Product Backlog in Zebra Jan 23, 2025
@mpguerra mpguerra moved this from Product Backlog to Sprint Backlog in Zebra Jan 23, 2025
@arya2
Copy link
Contributor

arya2 commented Feb 12, 2025

It could be useful to do this in zebra-state, perhaps by adding a Depth variant to HashOrHeight.

@mpguerra
Copy link
Contributor

It could be useful to do this in zebra-state, perhaps by adding a Depth variant to HashOrHeight.

Would this require a db upgrade?

@oxarbitrage
Copy link
Contributor

Would this require a db upgrade?

That should not be needed.

@oxarbitrage oxarbitrage added A-rpc Area: Remote Procedure Call interfaces A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Feb 22, 2025
@oxarbitrage oxarbitrage mentioned this issue Feb 22, 2025
Closed
5 tasks
@mpguerra mpguerra moved this from Sprint Backlog to Review/QA in Zebra Feb 24, 2025
@oxarbitrage oxarbitrage assigned upbqdn and unassigned oxarbitrage Mar 7, 2025
@mpguerra mpguerra linked a pull request Mar 7, 2025 that will close this issue
Support negative heights in HashOrHeight #9316
Draft
5 tasks
@mpguerra mpguerra moved this from Review/QA to In progress in Zebra Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@upbqdn upbqdn

Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage
Projects
Zebra
Status: In progress
Milestone
Zebra Ready for zcashd Deprecation
5 participants
@conradoplg @mpguerra @arya2 @upbqdn @oxarbitrage