Avoid having to set inline styles to hide modal by default. Fix issue kylefox#186

jaguadoromero · jaguadoromero · commit 48b20e48bf71 · 2017-10-17T20:46:38.000+02:00
diff --git a/jquery.modal.css b/jquery.modal.css
@@ -21,7 +21,7 @@
   background-color: transparent;
 }
 .modal {
-  display: inline-block;
+  display: none;
   vertical-align: middle;
   position: relative;
   z-index: 2;
diff --git a/jquery.modal.js b/jquery.modal.js
@@ -73,6 +73,7 @@
       }
     } else {
       this.$elm = el;
+      this.anchor = el;
       this.$body.append(this.$elm);
       this.open();
     }
@@ -143,9 +144,9 @@
       }
       this.$elm.addClass(this.options.modalClass).appendTo(this.$blocker);
       if(this.options.doFade) {
-        this.$elm.css('opacity',0).show().animate({opacity: 1}, this.options.fadeDuration);
+        this.$elm.css({opacity: 0, display: 'inline-block'}).animate({opacity: 1}, this.options.fadeDuration);
       } else {
-        this.$elm.show();
+        this.$elm.css('display', 'inline-block');
       }
       this.$elm.trigger($.modal.OPEN, [this._ctx()]);
     },

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`	`background-color: transparent;`
`22`	`22`	`}`
`23`	`23`	`.modal {`
`24`		`- display: inline-block;`
	`24`	`+ display: none;`
`25`	`25`	`vertical-align: middle;`
`26`	`26`	`position: relative;`
`27`	`27`	`z-index: 2;`
Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,7 @@`
`73`	`73`	`}`
`74`	`74`	`} else {`
`75`	`75`	`this.$elm = el;`
	`76`	`+ this.anchor = el;`
`76`	`77`	`this.$body.append(this.$elm);`
`77`	`78`	`this.open();`
`78`	`79`	`}`
`@@ -143,9 +144,9 @@`
`143`	`144`	`}`
`144`	`145`	`this.$elm.addClass(this.options.modalClass).appendTo(this.$blocker);`
`145`	`146`	`if(this.options.doFade) {`
`146`		`- this.$elm.css('opacity',0).show().animate({opacity: 1}, this.options.fadeDuration);`
	`147`	`+ this.$elm.css({opacity: 0, display: 'inline-block'}).animate({opacity: 1}, this.options.fadeDuration);`
`147`	`148`	`} else {`
`148`		`- this.$elm.show();`
	`149`	`+ this.$elm.css('display', 'inline-block');`
`149`	`150`	`}`
`150`	`151`	`this.$elm.trigger($.modal.OPEN, [this._ctx()]);`
`151`	`152`	`},`