Merge pull request #53 from runlevel5/ci/pin-actions-add-audit

(ci): bump actions, pin to SHA, add cargo audit

Author: ZeroX-DG

.github/workflows/main.yml

@@ -2,13 +2,16 @@ name: Main
 
 on: [push, pull_request]
 
+permissions:
+  contents: read
+
 jobs:
   lint:
     name: Lints Checks
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v4
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
 
       - name: Install stable toolchain
         run: |
@@ -33,8 +36,23 @@ jobs:
 
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v4
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
 
       - name: Run Tests
         run: |
           cargo test
+
+  audit:
+    name: Security Audit
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      checks: write
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+
+      - name: Run cargo audit
+        uses: rustsec/audit-check@69366f33c96575abad1ee0dba8212993eecbe998 # v2.0.0
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}

examples/repl.rs

@@ -5,11 +5,7 @@ fn main() {
     let method = "telex";
     let mut rl = DefaultEditor::new().unwrap();
 
-    loop {
-        let Ok(input) = rl.readline("(input): ") else {
-            break;
-        };
-
+    while let Ok(input) = rl.readline("(input): ") {
         let mut result = String::new();
 
         for word in input.split_whitespace() {

src/bin/vietnamese_generator.rs

@@ -66,32 +66,16 @@ fn is_valid_combination(initial: &str, rhyme: &str) -> bool {
 
     // Rule: k/g/ng vs c/gh/ngh
     match initial {
-        "c" | "g" | "ng" => {
-            if is_front_vowel_rhyme {
-                return false;
-            } // c, g, ng must be followed by other vowels.
-        }
-        "k" | "gh" | "ngh" => {
-            if !is_front_vowel_rhyme {
-                return false;
-            } // k, gh, ngh must be followed by i, e, ê, y.
-        }
-        "qu" => {
-            // 'qu' acts as a single unit and cannot be followed by a rhyme starting with 'u' or 'o'.
-            if "uo".contains(first_char_of_rhyme) {
-                return false;
-            }
-        }
-        "gi" => {
-            // Avoid "gi" + i-initial rhyme like "giiên", which is not a valid word.
-            if first_char_of_rhyme == 'i' {
-                return false;
-            }
-        }
-        _ => {}
+        // c, g, ng must be followed by other vowels.
+        "c" | "g" | "ng" if is_front_vowel_rhyme => false,
+        // k, gh, ngh must be followed by i, e, ê, y.
+        "k" | "gh" | "ngh" if !is_front_vowel_rhyme => false,
+        // 'qu' acts as a single unit and cannot be followed by a rhyme starting with 'u' or 'o'.
+        "qu" if "uo".contains(first_char_of_rhyme) => false,
+        // Avoid "gi" + i-initial rhyme like "giiên", which is not a valid word.
+        "gi" if first_char_of_rhyme == 'i' => false,
+        _ => true,
     }
-
-    true
 }
 
 /// Applies a tone mark to the correct vowel in a syllable.