Skip to content

Commit 13c99b1

Browse files
set correct typing fro defaults
1 parent 94cd360 commit 13c99b1

File tree

1 file changed

+47
-6
lines changed

1 file changed

+47
-6
lines changed

acclimatise/cli_types.py

Lines changed: 47 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class CliType:
1313
A data type used in the command-line
1414
"""
1515

16-
default: object = None
16+
default: Optional[typing.Any] = None
1717
"""
1818
A default value, None if unknown
1919
"""
@@ -36,6 +36,11 @@ class CliEnum(CliType):
3636
One of a list of possible options
3737
"""
3838

39+
default: Optional[Enum] = None
40+
"""
41+
A default value, None if unknown
42+
"""
43+
3944
enum: Enum
4045
"""
4146
The possible options as a Python Enum
@@ -48,7 +53,10 @@ class CliFloat(CliType):
4853
Takes a floating-point value
4954
"""
5055

51-
pass
56+
default: Optional[float] = None
57+
"""
58+
A default value, None if unknown
59+
"""
5260

5361

5462
@dataclass(unsafe_hash=True)
@@ -57,6 +65,11 @@ class CliInteger(CliType):
5765
Takes an integer value
5866
"""
5967

68+
default: Optional[int] = None
69+
"""
70+
A default value, None if unknown
71+
"""
72+
6073
_representable = {CliFloat}
6174

6275

@@ -66,7 +79,10 @@ class CliString(CliType):
6679
Takes a string value
6780
"""
6881

69-
pass
82+
default: Optional[str] = None
83+
"""
84+
A default value, None if unknown
85+
"""
7086

7187

7288
@dataclass(unsafe_hash=True)
@@ -75,7 +91,10 @@ class CliBoolean(CliType):
7591
Takes a boolean value
7692
"""
7793

78-
pass
94+
default: Optional[bool] = None
95+
"""
96+
A default value, None if unknown
97+
"""
7998

8099

81100
@dataclass(unsafe_hash=True)
@@ -84,7 +103,10 @@ class CliDir(CliType):
84103
Takes a directory path
85104
"""
86105

87-
pass
106+
default: Optional[str] = None
107+
"""
108+
A default value, None if unknown
109+
"""
88110

89111

90112
@dataclass(unsafe_hash=True)
@@ -93,7 +115,10 @@ class CliFile(CliType):
93115
Takes a file path
94116
"""
95117

96-
pass
118+
default: Optional[str] = None
119+
"""
120+
A default value, None if unknown
121+
"""
97122

98123

99124
@dataclass(unsafe_hash=True)
@@ -102,6 +127,11 @@ class CliDict(CliType):
102127
Takes a dictionary value
103128
"""
104129

130+
default: Optional[str] = None
131+
"""
132+
A default value, None if unknown
133+
"""
134+
105135
key: CliType
106136
"""
107137
Data type of the keys to this dictionary
@@ -119,6 +149,11 @@ class CliList(CliType):
119149
Takes a list value
120150
"""
121151

152+
default: Optional[typing.List[CliType]] = None
153+
"""
154+
A default value, None if unknown
155+
"""
156+
122157
value: CliType
123158
"""
124159
Data type of the values in this list
@@ -131,6 +166,12 @@ class CliTuple(CliType):
131166
Takes a list of values with a fixed length, possibly each with different types
132167
"""
133168

169+
default: Optional[typing.Tuple[CliType]] = None
170+
171+
"""
172+
A default value, None if unknown
173+
"""
174+
134175
values: typing.List[CliType]
135176
"""
136177
List of types, in order, held within the tuple

0 commit comments

Comments
 (0)