-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is possible to add PIP feature for mobile? #66
Comments
I can try to add it for Android, but not sure I can make it work for iOS. If that's what you want let me know |
For Android it would already be a good step. I saw that even for iOS it is possible to do it now. |
Due to not having an iOS I may not be able to do it. But I will try anyway. |
thank you very much! |
@0Franky i was able to do it on android, for ios i would love if you can make a pr.
|
thank you @zezo357 ! for iOS I'll try to install MacOS in VM and I'll try to code it using iOS emulator. |
I did try to run macos in vm before and failed, if you managed to succeed let me know the steps |
sure. are you ok Windows or Linux? however you can refer to this: |
I am on windows, and will check it thank you |
On Android PIP works well, thank you! Just a question, to change the PIP UI, can I do it by flutter code? |
I didn't find a way yet, this is why I didn't release it 😅 if I found a way I will implement it Most probably we can't change it. But we maybe able to remove some. |
couldnt find a way to change ui (keep in mind i am not that good with java, nor swift) for ios , pip will require help from the people |
Ok in the meantime, can we show the following buttons?
|
I'll try to write some code in the next days. But I never wrote swift code 😅 nor flutter package |
For ios pip mode I found this fork of video_player It seems you are using video_player for mobile version. What do you think about using this fork? Or at least take into account the code as a guide for our. |
Will check it |
Thank you, I hope it can speed up |
I don't know if it's even possible based on my current knowledge 🥲. Since most people use pip from the player itself so I would have to make my own video_player like how you see in that repo |
Hi @zezo357 ,
first of all thank you for your contribution!
I wanted to ask as the title suggests if is possible to add the PIP feature (for mobile).
I noticed there is already a pip control but it only works for the web.
Can you add this feature for mobile too?
Thanks in advance and have a nice day!
The text was updated successfully, but these errors were encountered: