Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is possible to add PIP feature for mobile? #66

Open
0Franky opened this issue May 8, 2023 · 18 comments
Open

Is possible to add PIP feature for mobile? #66

0Franky opened this issue May 8, 2023 · 18 comments
Labels
help wanted Extra attention is needed

Comments

@0Franky
Copy link
Contributor

0Franky commented May 8, 2023

Hi @zezo357 ,
first of all thank you for your contribution!

I wanted to ask as the title suggests if is possible to add the PIP feature (for mobile).
I noticed there is already a pip control but it only works for the web.

Can you add this feature for mobile too?

Thanks in advance and have a nice day!

@abdelaziz-mahdy
Copy link
Owner

Hi @zezo357 ,
first of all thank you for your contribution!

I wanted to ask as the title suggests if is possible to add the PIP feature (for mobile).
I noticed there is already a pip control but it only works for the web.

Can you add this feature for mobile too?

Thanks in advance and have a nice day!

I can try to add it for Android, but not sure I can make it work for iOS. If that's what you want let me know

@0Franky
Copy link
Contributor Author

0Franky commented May 8, 2023

For Android it would already be a good step.

I saw that even for iOS it is possible to do it now.
If it were possible to add the same feature to iOS as well, that would be great.

@abdelaziz-mahdy
Copy link
Owner

For Android it would already be a good step.

I saw that even for iOS it is possible to do it now.
If it were possible to add the same feature to iOS as well, that would be great.

Due to not having an iOS I may not be able to do it.

But I will try anyway.

@0Franky
Copy link
Contributor Author

0Franky commented May 8, 2023

thank you very much!

@abdelaziz-mahdy
Copy link
Owner

abdelaziz-mahdy commented May 8, 2023

@0Franky i was able to do it on android, for ios i would love if you can make a pr.
for android you can test on latest branch (check documention website for steps to setup)
👋 👉 Complete documentation here

  flutter_meedu_videoplayer:
    git:
      url: https://github.com/zezo357/flutter_meedu_videoplayer
      path: package

@abdelaziz-mahdy abdelaziz-mahdy added the waiting for confirmation waiting for confirmation of fix label May 8, 2023
@0Franky
Copy link
Contributor Author

0Franky commented May 9, 2023

thank you @zezo357 !
today I'll check it and I'll give you more details.

for iOS I'll try to install MacOS in VM and I'll try to code it using iOS emulator.
but I'm not sure about the result because I never programmed in swift.

@abdelaziz-mahdy
Copy link
Owner

thank you @zezo357 !
today I'll check it and I'll give you more details.

for iOS I'll try to install MacOS in VM and I'll try to code it using iOS emulator.
but I'm not sure about the result because I never programmed in swift.

I did try to run macos in vm before and failed, if you managed to succeed let me know the steps

@0Franky
Copy link
Contributor Author

0Franky commented May 9, 2023

sure. are you ok Windows or Linux?

however you can refer to this:
https://github.com/sickcodes/Docker-OSX

@abdelaziz-mahdy
Copy link
Owner

sure. are you ok Windows or Linux?

however you can refer to this:
https://github.com/sickcodes/Docker-OSX

I am on windows, and will check it thank you

@0Franky
Copy link
Contributor Author

0Franky commented May 9, 2023

On Android PIP works well, thank you!

Just a question, to change the PIP UI, can I do it by flutter code?

@abdelaziz-mahdy
Copy link
Owner

abdelaziz-mahdy commented May 9, 2023

On Android PIP works well, thank you!

Just a question, to change the PIP UI, can I do it by flutter code?

I didn't find a way yet, this is why I didn't release it 😅 if I found a way I will implement it

Most probably we can't change it. But we maybe able to remove some.

@abdelaziz-mahdy
Copy link
Owner

couldnt find a way to change ui (keep in mind i am not that good with java, nor swift)

for ios , pip will require help from the people

@abdelaziz-mahdy abdelaziz-mahdy added help wanted Extra attention is needed and removed waiting for confirmation waiting for confirmation of fix labels May 12, 2023
@0Franky
Copy link
Contributor Author

0Franky commented May 15, 2023

On Android PIP works well, thank you!
Just a question, to change the PIP UI, can I do it by flutter code?

I didn't find a way yet, this is why I didn't release it 😅 if I found a way I will implement it

Most probably we can't change it. But we maybe able to remove some.

Ok in the meantime, can we show the following buttons?

  • close pip (top right)
  • restore normal mode (center)
  • play/pause (bottom center)
  • backward/forward (bottom left/right)

@0Franky
Copy link
Contributor Author

0Franky commented May 15, 2023

couldnt find a way to change ui (keep in mind i am not that good with java, nor swift)

for ios , pip will require help from the people

I'll try to write some code in the next days. But I never wrote swift code 😅 nor flutter package

@0Franky
Copy link
Contributor Author

0Franky commented May 15, 2023

For ios pip mode I found this fork of video_player
https://github.com/vanlooverenkoen/flutter-packages/tree/feature/%2360048-ios-picture-in-picture

It seems you are using video_player for mobile version.

What do you think about using this fork? Or at least take into account the code as a guide for our.

@abdelaziz-mahdy
Copy link
Owner

For ios pip mode I found this fork of video_player
https://github.com/vanlooverenkoen/flutter-packages/tree/feature/%2360048-ios-picture-in-picture

It seems you are using video_player for mobile version.

What do you think about using this fork? Or at least take into account the code as a guide for our.

Will check it

@0Franky
Copy link
Contributor Author

0Franky commented May 22, 2023

For ios pip mode I found this fork of video_player
https://github.com/vanlooverenkoen/flutter-packages/tree/feature/%2360048-ios-picture-in-picture
It seems you are using video_player for mobile version.
What do you think about using this fork? Or at least take into account the code as a guide for our.

Will check it

Thank you, I hope it can speed up

@abdelaziz-mahdy
Copy link
Owner

For ios pip mode I found this fork of video_player
https://github.com/vanlooverenkoen/flutter-packages/tree/feature/%2360048-ios-picture-in-picture
It seems you are using video_player for mobile version.
What do you think about using this fork? Or at least take into account the code as a guide for our.

Will check it

Thank you, I hope it can speed up

I don't know if it's even possible based on my current knowledge 🥲. Since most people use pip from the player itself so I would have to make my own video_player like how you see in that repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants