Some modernisation of QtPropertyBrowser #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced emit, slots and foreach with Q_EMIT, Q_SLOTS and Q_FOREACH.
Replaced with QColorDialog::getColor() which is simpler anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting to use QtPropertyBrowser on a new project and ran into a couple of problems. We compile with CONFIG = no_keywords, so I replaced emit, foreach and slots with their Q_ macro equivalents, which also work if no_keywords hasn't been defined. I also replaced use of the obsolete method QColorDialog::getRgba() with QColorDialog::getColor(). It's been available since Qt 4.5 so should be OK to use and it's cleaner in this use case.