Onthefly repo for AuthCodeManager

This avoids a database connection to be established for every request
Completes fix for issue FriendsOfSymfony#422

Author: abienvenu

Document/AuthCodeManager.php

@@ -14,7 +14,6 @@
 namespace FOS\OAuthServerBundle\Document;
 
 use Doctrine\ODM\MongoDB\DocumentManager;
-use Doctrine\ODM\MongoDB\DocumentRepository;
 use FOS\OAuthServerBundle\Model\AuthCodeInterface;
 use FOS\OAuthServerBundle\Model\AuthCodeManager as BaseAuthCodeManager;
 
@@ -25,24 +24,14 @@ class AuthCodeManager extends BaseAuthCodeManager
      */
     protected $dm;
 
-    /**
-     * @var DocumentRepository
-     */
-    protected $repository;
-
     /**
      * @var string
      */
     protected $class;
 
     public function __construct(DocumentManager $dm, $class)
     {
-        // NOTE: bug in Doctrine, hinting DocumentRepository|ObjectRepository when only DocumentRepository is expected
-        /** @var DocumentRepository $repository */
-        $repository = $dm->getRepository($class);
-
         $this->dm = $dm;
-        $this->repository = $repository;
         $this->class = $class;
     }
 
@@ -59,7 +48,7 @@ public function getClass()
      */
     public function findAuthCodeBy(array $criteria)
     {
-        return $this->repository->findOneBy($criteria);
+        return $this->dm->getRepository($this->class)->findOneBy($criteria);
     }
 
     /**
@@ -85,8 +74,10 @@ public function deleteAuthCode(AuthCodeInterface $authCode)
      */
     public function deleteExpired()
     {
-        $result = $this
-            ->repository
+        /** @var \Doctrine\ODM\MongoDB\DocumentRepository $repository */
+        $repository = $this->dm->getRepository($this->class);
+
+        $result = $repository
             ->createQueryBuilder()
             ->remove()
             ->field('expiresAt')->lt(time())

Tests/Document/AuthCodeManagerTest.php

@@ -65,13 +65,6 @@ public function setUp()
         ;
         $this->className = 'TestClassName'.\random_bytes(5);
 
-        $this->documentManager
-            ->expects($this->once())
-            ->method('getRepository')
-            ->with($this->className)
-            ->willReturn($this->repository)
-        ;
-
         $this->instance = new AuthCodeManager($this->documentManager, $this->className);
 
         parent::setUp();
@@ -95,6 +88,13 @@ public function testFindAuthCodeBy()
             \random_bytes(10),
         ];
 
+        $this->documentManager
+            ->expects($this->once())
+            ->method('getRepository')
+            ->with($this->className)
+            ->willReturn($this->repository)
+        ;
+
         $this->repository
             ->expects($this->once())
             ->method('findOneBy')
@@ -155,6 +155,13 @@ public function testDeleteAuthCode()
 
     public function testDeleteExpired()
     {
+        $this->documentManager
+            ->expects($this->once())
+            ->method('getRepository')
+            ->with($this->className)
+            ->willReturn($this->repository)
+        ;
+
         $queryBuilder = $this->getMockBuilder(Builder::class)
             ->disableOriginalConstructor()
             ->getMock()