Skip to content

Commit acd8dda

Browse files
authored
Merge pull request #255 from thomasscheer/fixIssue240
Remove None wheel URLs before sorting them
2 parents b9df6f9 + a798f9a commit acd8dda

38 files changed

Lines changed: 788 additions & 753 deletions

.github/workflows/docs-ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ jobs:
1313

1414
steps:
1515
- name: Checkout code
16-
uses: actions/checkout@v4
16+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
1717

1818
- name: Set up Python ${{ matrix.python-version }}
19-
uses: actions/setup-python@v5
19+
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
2020
with:
2121
python-version: ${{ matrix.python-version }}
2222

.github/workflows/pypi-release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ jobs:
2424
runs-on: ubuntu-24.04
2525

2626
steps:
27-
- uses: actions/checkout@v4
27+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2828
- name: Set up Python
29-
uses: actions/setup-python@v5
29+
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
3030
with:
3131
python-version: 3.14
3232

src/python_inspector/package_data.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,8 @@ async def get_pypi_data_from_purl(
122122

123123

124124
def choose_single_wheel(wheel_urls: List[str]) -> Optional[str]:
125+
# fix Issue 240 - TypeError: '<' not supported between instances of 'str' and 'NoneType'
126+
wheel_urls = [url for url in wheel_urls if url is not None]
125127
"""
126128
Sort wheel urls descendingly and return the first one
127129
"""

tests/data/azure-devops.req-310-expected.json

Lines changed: 113 additions & 118 deletions
Large diffs are not rendered by default.

tests/data/azure-devops.req-312-expected.json

Lines changed: 113 additions & 118 deletions
Large diffs are not rendered by default.

tests/data/azure-devops.req-313-expected.json

Lines changed: 113 additions & 118 deletions
Large diffs are not rendered by default.

tests/data/azure-devops.req-314-expected.json

Lines changed: 113 additions & 118 deletions
Large diffs are not rendered by default.

tests/data/azure-devops.req-38-expected.json

Lines changed: 34 additions & 33 deletions
Large diffs are not rendered by default.

tests/data/default-url-expected.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"headers": {
33
"tool_name": "python-inspector",
44
"tool_homepageurl": "https://github.com/aboutcode-org/python-inspector",
5-
"tool_version": "0.13.0",
65
"options": [
76
"--index-url https://pypi.org/simple",
87
"--json <file>",

tests/data/environment-marker-test-requirements.txt-expected.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"headers": {
33
"tool_name": "python-inspector",
44
"tool_homepageurl": "https://github.com/aboutcode-org/python-inspector",
5-
"tool_version": "0.13.0",
65
"options": [
76
"--index-url https://pypi.org/simple",
87
"--json-pdt <file>",

0 commit comments

Comments
 (0)