-
-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: AssertError@src/itemdb.d(892): Assertion failure #3143
Comments
I'll monitor it further, but seems to be also realted to #3115 altough not directly obvious as trace was different. |
Seems like the same thing I was referring to in #3122 (comment) |
Exactly the same here, on Kubuntu 24.04.2
|
@sebastian-be , @dimsinel , @cyb3rko It is:
Please stop raising new issues for known problems! |
Gladly BUT ... as trace was different, I was unable to identify as same. Only after trying other workaround, was able to confirm... |
@sebastian-be The clue here is this:
This is the cause ... and is failing because:
|
To those watching | impacted by this bug(s) I was working on this issue heavily yesterday (1st March 2025) and the solution was working rather well with all testing. This morning, when I was re validating the code, overnight there has been an account change to all of my OneDrive Personal accounts where the accounts now have the 'sea8cc6beffdb43d7976fbc7da445c639' Microsoft change. As such, when I now query the API for all the folders online, the /delta query that this client heavily uses no longer is providing the Shared Folder JSON data that the /delta query was providing yesterday before the 'sea8cc6beffdb43d7976fbc7da445c639' account change. I have raised a bug with Microsoft for this issue - but until this data quality issue from the Microsoft OneDrive API is fixed, a full resolution for this insideous series of bugs caused by this 'sea8cc6beffdb43d7976fbc7da445c639' change cannot be resolved. The new API bug is listed here: OneDrive/onedrive-api-docs#1891 |
To those watching | impacted by this bug(s) Caution This maybe a 100% coding fix - however at the moment this needs a workaround to also be implemented by impacted users Please can you test this updated PR and provide valuable feedback. To test the PR, first install all the require platform dependencies to build the client on your respective platforms. Please read https://github.com/abraunegg/onedrive/blob/master/docs/install.md#building-from-source---high-level-requirements and then follow correctly for your platform. Important Currently there is an issue with installing the DMD or LDC compiler using the documentation instructions: This is not something I can solve and I have emailed the appropriate folk and raised dlang/dmd#20830 Please augment the installation of DMD or LDC with your distribution version if it is available Once this is done, to clone the PR to resolve your issue, you can use a script like the following:
This script will create a local folder called Important Before running this PR please add to your configuration file This will bypass the new OneDrive API /delta bug OneDrive/onedrive-api-docs#1891 where OneDrive Personal Folder details are no longer sent in the /delta response when your account has been migrated to the new Microsoft OneDrive platform. You can tell when you are impacted as when you run the application in verbose mode, it will look like this:
To run the PR, you need to run the client from the PR build directory:
To install the PR, you will need to perform When running the PR, your version should be: If you still encounter an issue, please generate a new verbose debug log following this process: https://github.com/abraunegg/onedrive/wiki/Generate-debug-log-for-support |
Output:
|
@sebastian-be |
That was one-off run. The process was quite slow, given the number of files / directories involved. Given I use webhooks I've set it high, but default is 300, and my sync is now taking about that much. Thank you, for info and effort. Much appreciated. |
This is because the client, when using the 'force children scan' developer option, it is having to manually build your tree - because Microsoft broke the /delta API query when they have moved everyone's account to a new backend platform. The details for this API bug can be found here: OneDrive/onedrive-api-docs#1891 Please also rebuild your client to Whilst forcing to use /children is a way for users to start using Microsoft OneDrive again, ideally Microsoft should fix the /delta bug so that some performance speed can be brought back. |
Thx for update. Would you mind clarifying: is the sync process a "background" task, meaning other stuff, like for example treating webhook, still happen concurrently? |
Webhooks and everything else is impacted by these API bugs. The PR works around these bugs that Microsoft introduced. If you use There should be no real impact to using webhooks except you must use this PR to work around the API bugs and implement the child scan method due to the /delta bug that Microsoft introduced. Net effect - you have 2 choices:
|
The fix works for me as well |
To those watching | impacted by this bug(s) Please rebuild your PR client version to It potentially appears that Microsoft has resolved the /delta API query bug that failed to send OneDrive Personal Shared Folder details, thus potentially you may be able to stop the use of the If you get this sort of error or similar without
You need to re-enable When using this client version, please use Please can you test this client version and advise. |
Thx for 'ping'!
Second with verbose
|
Thanks for working so hard to get this fixed and deal with Microsoft on this! @abraunegg |
Tried a manual resync with onedrive v2.5.4-37-g53656b3, without "force_children_scan". It worked fine! It took a few minutes to complete. I used I noticed the lack of response in the onedrive-api-docs repo. It still seems like @abraunegg 's persistent efforts to make MS aware of the issues gave results. This is a very well-maintained project, even though there is only a single major contributor. That is admirable. The project deserves more helping hands and contributions (work or donations) going forward, in my opinion. |
To those watching | impacted by these bug(s) Many thanks for your patience and feedback whilst these issues were being resolved. It is greatly appreciated. |
To those watching | impacted by this bug(s) As all 4 issue tickets are now marked as fixed, PR #3116 will be merged into 'master'. Please rebuild your client from 'master' when possible, and please keep an eye out for v2.5.5 when that is released. |
Describe the bug
When running onedrive either --sync or --monitor, following error occurs (syslog of --monitor)
Please indicate if / what more info is needed?
Operating System Details
DISTRIB_ID=Ubuntu DISTRIB_RELEASE=24.04 DISTRIB_CODENAME=noble DISTRIB_DESCRIPTION="Ubuntu 24.04.2 LTS"
Client Installation Method
From 3rd Party Source (PPA, OpenSuSE Build Service etc)
OneDrive Account Type
Personal
What is your OneDrive Application Version
onedrive v2.5.4-1+np1+1.1
What is your OneDrive Application Configuration
What is your 'curl' version
Where is your 'sync_dir' located
Local
What are all your system 'mount points'
What are all your local file system partition types
How do you use 'onedrive'
onedrive folder is shared using samba
same acount is also setup on another system, windows with native onedrive client
Steps to reproduce the behaviour
onedrive --sync or
onecrive --monitor
at the end, after db cleanup exception occurs
Complete Verbose Log Output
Screenshots
No response
Other Log Information or Details
n/a, no entries during exec
Additional context
No response
The text was updated successfully, but these errors were encountered: