Internal cleanup

PiperOrigin-RevId: 950841043
Change-Id: I8948415dec8790c284a31738bd037572a7ddbba2

Author: pefoley2

absl/random/internal/BUILD.bazel

@@ -194,6 +194,7 @@ cc_library(
         ":platform",
         ":randen",
         ":seed_material",
+        "//absl/algorithm:container",
         "//absl/base",
         "//absl/base:config",
         "//absl/base:core_headers",
@@ -367,8 +368,9 @@ cc_library(
     deps = [
         ":platform",
         ":randen_hwaes",
+        ":randen_hwaes_impl",
         ":randen_slow",
-        "//absl/base:raw_logging_internal",
+        "//absl/base:config",
     ],
 )
 
@@ -394,13 +396,11 @@ cc_library(
     ],
     hdrs = [
         "randen_detect.h",
-        "randen_hwaes.h",
     ],
     copts = ABSL_DEFAULT_COPTS,
     linkopts = ABSL_DEFAULT_LINKOPTS,
     deps = [
         ":platform",
-        ":randen_hwaes_impl",
         "//absl/base:config",
     ],
 )
@@ -410,6 +410,8 @@ cc_library(
     name = "randen_hwaes_impl",
     srcs = [
         "randen_hwaes.cc",
+    ],
+    hdrs = [
         "randen_hwaes.h",
     ],
     copts = ABSL_DEFAULT_COPTS + ABSL_RANDOM_RANDEN_COPTS + select({
@@ -421,7 +423,6 @@ cc_library(
     deps = [
         ":platform",
         "//absl/base:config",
-        "//absl/base:core_headers",
         "//absl/numeric:int128",
     ],
 )
@@ -433,6 +434,7 @@ cc_binary(
     ],
     linkopts = ABSL_DEFAULT_LINKOPTS,
     deps = [
+        "//absl/base:config",
         "//absl/base:core_headers",
         "//absl/random:distributions",
     ],
@@ -537,7 +539,8 @@ cc_test(
     linkopts = ABSL_DEFAULT_LINKOPTS,
     deps = [
         ":explicit_seed_seq",
-        "//absl/random:seed_sequences",
+        "//absl/base:config",
+        "//absl/base:core_headers",
         "@googletest//:gtest",
         "@googletest//:gtest_main",
     ],
@@ -551,6 +554,8 @@ cc_test(
     linkopts = ABSL_DEFAULT_LINKOPTS,
     deps = [
         ":salted_seed_seq",
+        ":seed_material",
+        "//absl/base:core_headers",
         "@googletest//:gtest",
         "@googletest//:gtest_main",
     ],
@@ -566,6 +571,7 @@ cc_test(
     linkopts = ABSL_DEFAULT_LINKOPTS,
     deps = [
         ":distribution_test_util",
+        "//absl/algorithm:container",
         "//absl/base:core_headers",
         "@googletest//:gtest",
         "@googletest//:gtest_main",
@@ -582,6 +588,7 @@ cc_test(
     linkopts = ABSL_DEFAULT_LINKOPTS,
     deps = [
         ":fast_uniform_bits",
+        "//absl/base:config",
         "@googletest//:gtest",
         "@googletest//:gtest_main",
     ],
@@ -621,8 +628,8 @@ cc_test(
     linkopts = ABSL_DEFAULT_LINKOPTS,
     deps = [
         ":nonsecure_base",
+        "//absl/algorithm:container",
         "//absl/container:flat_hash_set",
-        "//absl/meta:type_traits",
         "//absl/random",
         "//absl/random:distributions",
         "//absl/synchronization",
@@ -672,7 +679,6 @@ cc_test(
     deps = [
         ":explicit_seed_seq",
         ":pcg_engine",
-        "//absl/time",
         "@googletest//:gtest",
         "@googletest//:gtest_main",
     ],
@@ -690,7 +696,6 @@ cc_test(
         ":explicit_seed_seq",
         ":randen_engine",
         "//absl/log",
-        "//absl/strings",
         "//absl/time",
         "@googletest//:gtest",
         "@googletest//:gtest_main",
@@ -705,7 +710,6 @@ cc_test(
     linkopts = ABSL_DEFAULT_LINKOPTS,
     deps = [
         ":randen",
-        "//absl/meta:type_traits",
         "@googletest//:gtest",
         "@googletest//:gtest_main",
     ],
@@ -720,7 +724,6 @@ cc_test(
     deps = [
         ":platform",
         ":randen_slow",
-        "//absl/base:endian",
         "@googletest//:gtest",
         "@googletest//:gtest_main",
     ],
@@ -738,7 +741,6 @@ cc_test(
         ":randen_hwaes",
         ":randen_hwaes_impl",  # build_cleaner: keep
         "//absl/log",
-        "//absl/strings:str_format",
         "@googletest//:gtest",
     ],
 )
@@ -750,6 +752,7 @@ cc_test(
     copts = ABSL_TEST_COPTS,
     linkopts = ABSL_DEFAULT_LINKOPTS,
     deps = [
+        ":traits",
         ":wide_multiply",
         "//absl/numeric:int128",
         "@googletest//:gtest",
@@ -765,6 +768,7 @@ cc_library(
     deps = [
         ":platform",
         ":randen_engine",
+        "//absl/algorithm:container",
         "//absl/base:config",
         "//absl/base:core_headers",
         "//absl/base:raw_logging_internal",
@@ -811,6 +815,7 @@ cc_test(
     ],
     deps = [
         ":nanobenchmark",
+        "//absl/base:config",
         "//absl/log",
         "//absl/log:check",
         "//absl/strings",
@@ -829,7 +834,6 @@ cc_test(
     tags = ABSL_RANDOM_NONPORTABLE_TAGS + ["benchmark"],
     deps = [
         ":nanobenchmark",
-        ":platform",
         ":randen",
         ":randen_engine",
         ":randen_hwaes",

absl/random/internal/chi_square.cc

@@ -16,6 +16,7 @@
 
 #include <cmath>
 
+#include "absl/base/config.h"
 #include "absl/random/internal/distribution_test_util.h"
 
 namespace absl {

absl/random/internal/chi_square_test.cc

@@ -22,6 +22,7 @@
 #include <vector>
 
 #include "gtest/gtest.h"
+#include "absl/algorithm/container.h"
 #include "absl/base/macros.h"
 
 using absl::random_internal::ChiSquare;
@@ -176,8 +177,8 @@ TEST(ChiSquareTest, CalcChiSquareInt64) {
   // $ python -c "import scipy.stats
   // > print scipy.stats.chisquare([910293487, 910292491, 910216780])[0]"
   // 4.25410123524
-  double sum = std::accumulate(std::begin(data), std::end(data), double{0});
-  size_t n = std::distance(std::begin(data), std::end(data));
+  double sum = absl::c_accumulate(data, double{0});
+  size_t n = absl::c_distance(data);
   double a = ChiSquareWithExpected(std::begin(data), std::end(data), sum / n);
   EXPECT_NEAR(4.254101, a, 1e-6);
 
@@ -343,8 +344,8 @@ TEST(ChiSquareTest, DiceRolls) {
   // The dof value of 4, @95% = 9.488 (see above test)
   // The dof value of 5, @95% = 11.070
   const int rolls[6] = {22, 11, 17, 14, 20, 18};
-  double sum = std::accumulate(std::begin(rolls), std::end(rolls), double{0});
-  size_t n = std::distance(std::begin(rolls), std::end(rolls));
+  double sum = absl::c_accumulate(rolls, double{0});
+  size_t n = absl::c_distance(rolls);
 
   double a = ChiSquareWithExpected(std::begin(rolls), std::end(rolls), sum / n);
   EXPECT_NEAR(a, 4.70588, 1e-5);

absl/random/internal/distribution_test_util.cc

@@ -14,15 +14,20 @@
 
 #include "absl/random/internal/distribution_test_util.h"
 
+#include <algorithm>
 #include <cassert>
 #include <cmath>
+#include <limits>
+#include <ostream>
 #include <string>
-#include <vector>
 
+#include "absl/base/config.h"
 #include "absl/base/internal/raw_logging.h"
 #include "absl/base/macros.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
+#include "absl/strings/string_view.h"
+#include "absl/types/span.h"
 
 namespace absl {
 ABSL_NAMESPACE_BEGIN

absl/random/internal/distribution_test_util_test.cc

@@ -14,6 +14,9 @@
 
 #include "absl/random/internal/distribution_test_util.h"
 
+#include <utility>
+#include <vector>
+
 #include "gtest/gtest.h"
 
 namespace {

absl/random/internal/entropy_pool.cc

@@ -20,6 +20,7 @@
 #include <cstring>
 #include <iterator>
 
+#include "absl/algorithm/container.h"
 #include "absl/base/attributes.h"
 #include "absl/base/call_once.h"
 #include "absl/base/config.h"
@@ -56,21 +57,21 @@ class alignas(std::max(size_t{ABSL_CACHELINE_SIZE}, size_t{32}))
 
   void Init(absl::Span<const uint32_t> data) {
     SpinLockHolder l(mu_);  // Always uncontested.
-    std::copy(data.begin(), data.end(), std::begin(state_));
+    absl::c_copy(data, std::begin(state_));
     next_ = kState;
   }
 
   // Copy bytes into out.
   void Fill(uint8_t* out, size_t bytes) ABSL_LOCKS_EXCLUDED(mu_);
 
-  inline void MaybeRefill() ABSL_EXCLUSIVE_LOCKS_REQUIRED(mu_) {
+  void MaybeRefill() ABSL_EXCLUSIVE_LOCKS_REQUIRED(mu_) {
     if (next_ >= kState) {
       next_ = kCapacity;
       impl_.Generate(state_);
     }
   }
 
-  inline size_t available() const ABSL_SHARED_LOCKS_REQUIRED(mu_) {
+  size_t available() const ABSL_SHARED_LOCKS_REQUIRED(mu_) {
     return kState - next_;
   }
 

absl/random/internal/explicit_seed_seq_test.cc

@@ -14,13 +14,17 @@
 
 #include "absl/random/internal/explicit_seed_seq.h"
 
+#include <cstddef>
+#include <cstdint>
 #include <iterator>
 #include <random>
 #include <utility>
+#include <vector>
 
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
-#include "absl/random/seed_sequences.h"
+#include "absl/base/config.h"
+#include "absl/base/macros.h"
 
 namespace {
 

absl/random/internal/fast_uniform_bits_test.cc

@@ -14,9 +14,13 @@
 
 #include "absl/random/internal/fast_uniform_bits.h"
 
+#include <cstddef>
+#include <cstdint>
+#include <limits>
 #include <random>
 
 #include "gtest/gtest.h"
+#include "absl/base/config.h"
 
 namespace absl {
 ABSL_NAMESPACE_BEGIN

absl/random/internal/fastmath_test.cc

@@ -14,6 +14,9 @@
 
 #include "absl/random/internal/fastmath.h"
 
+#include <cmath>
+#include <cstdint>
+
 #include "gtest/gtest.h"
 
 #if defined(__EMSCRIPTEN__)

absl/random/internal/gaussian_distribution_gentables.cc

@@ -22,6 +22,7 @@
 #include <limits>
 #include <string>
 
+#include "absl/base/config.h"
 #include "absl/base/macros.h"
 #include "absl/random/gaussian_distribution.h"