[FEAT] Enable to add annotations to the listeners

[laserpedro]

What would you like added?

listenerTemplate:
    metadata:
      annotations:
      prometheus.io/scrape: true
      prometheus.io/path: /metrics
      prometheus.io/port: 8080

Why is this needed?

We need this to be able to scrap the listener metrics that are very useful for jobs, steps monitoring

Additional context

Let me know if you want more.

[github-actions]

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

[jef]

You can add metrics to the listener, but you're missing the spec.containers:

listenerTemplate:
  metadata:
    annotations:
      prometheus.io/scrape: true
      prometheus.io/path: /metrics
      prometheus.io/port: 8080
  spec:
    containers:
      - name: listener

[laserpedro]

@jef there must be sth I missed here: I added the listener template spec part but once done the runners are reconciled by argoCD but no pods are created now when a job request a runner .....

[michalschott]

hey @jef, I think @laserpedro asked for annotations for autoscalingrunnerlistener not a pod.

I'm facing similar issue rn, where I have to manually annotate these created by controller.

[laserpedro]

Hello @jef ,

Yes exactly as mentioned by @michalschott, thank you 👍

We have an auto scale down/up mechanism of our warm pool during certain hours, weekends so the listeners for our different flavor of runners are frequently re-created and we are loosing the annotations and therefore the monitoring ...