Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Maven distribution downloaded by Maven Wrapper #448

Open
Marcono1234 opened this issue Jan 29, 2023 · 6 comments · May be fixed by #453
Open

Cache Maven distribution downloaded by Maven Wrapper #448

Marcono1234 opened this issue Jan 29, 2023 · 6 comments · May be fixed by #453
Labels
feature request New feature or request to improve the current logic

Comments

@Marcono1234
Copy link
Contributor

Description:
Cache the Maven distribution downloaded by the official Maven Wrapper.

The cache key should probably be derived from the .mvn/wrapper/maven-wrapper.properties file (see documentation), similar to how it is done already for the Gradle Wrapper.

The directory to cache is ~/.m2/wrapper/dists (see documentation).

Justification:
Without caching, projects using the Maven Wrapper would have to download the Maven distribution (~8MB) every time the project is built.

For Gradle the setup-java action already supports caching the Gradle distribution downloaded by the wrapper:

setup-java/src/cache.ts

Line 36 in 8f12c5c

'**/gradle-wrapper.properties',

setup-java/src/cache.ts

Line 32 in 8f12c5c

path: [join(os.homedir(), '.gradle', 'caches'), join(os.homedir(), '.gradle', 'wrapper')],

Are you willing to submit a PR?

Probably not
@Marcono1234 Marcono1234 added feature request New feature or request to improve the current logic needs triage labels Jan 29, 2023
@Marcono1234 Marcono1234 mentioned this issue Jan 29, 2023
Open
@IvanZosimov
Copy link
Contributor

Hi, @Marcono1234 👋 Thank you for the feature request! We will investigate it and get back to you with our decision as soon as possible.

yeikel added a commit to yeikel/setup-java that referenced this issue Feb 12, 2023
@yeikel
Cache Maven distribution downloaded by Maven Wrapper
523ea1c 
Closes actions#448
yeikel added a commit to yeikel/setup-java that referenced this issue Feb 12, 2023
@yeikel
Cache Maven Wrapper
71b1d09 
Closes actions#448
yeikel added a commit to yeikel/setup-java that referenced this issue Feb 12, 2023
@yeikel
Cache Maven Wrapper
edec6fe 
Closes actions#448
yeikel added a commit to yeikel/setup-java that referenced this issue Feb 12, 2023
@yeikel
Cache Maven Wrapper
5d7284b 
Closes actions#448
@yeikel yeikel linked a pull request Feb 12, 2023 that will close this issue
Open
@yeikel
Copy link

yeikel commented Feb 16, 2023

@IvanZosimov I submitted #453 for this

@fadma10
Copy link

fadma10 commented Apr 20, 2023

it's runing

@IvanZosimov IvanZosimov linked a pull request Jul 7, 2023 that will close this issue
Cache Maven Distributions downloaded by the Maven Wrapper #453
Open
@seepine
Copy link

seepine commented Jul 14, 2023

@yeikel Hi, maybe you can support gradlew also, this is really useful of cache mvnw and gradlew

@yeikel
Copy link

yeikel commented Jul 14, 2023

@yeikel Hi, maybe you can support gradlew also, this is really useful of cache mvnw and gradlew

I think that we should track that separately

@seepine
Copy link

seepine commented Jul 14, 2023

@yeikel Hi, maybe you can support gradlew also, this is really useful of cache mvnw and gradlew

I think that we should track that separately

You are right, maybe not work of cache gradlew due to excessive cache size, i find it work just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache Maven Distributions downloaded by the Maven Wrapper yeikel/setup-java
5 participants
@yeikel @Marcono1234 @seepine @IvanZosimov @fadma10