Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint output indentation breaks problem matcher (Nx monorepo support) #1244

Open
2 of 5 tasks
fregante opened this issue Mar 9, 2025 · 1 comment · May be fixed by #1245
Open
2 of 5 tasks

eslint output indentation breaks problem matcher (Nx monorepo support) #1244

fregante opened this issue Mar 9, 2025 · 1 comment · May be fixed by #1245
Assignees
Labels
bug Something isn't working

Comments

@fregante
Copy link

fregante commented Mar 9, 2025

Description:

Annotations don't appear when eslint is indented. This happens when using tools like https://nx.dev that orchestrate and group script/tasks in large repos.

It seems that Jest's matcher is not affected

Action version:

v4

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

  "engines": {
    "node": "22.14.0",
    "npm": "10.9.2"
  },

Repro steps:

Output this code to console on CI

Problem matched:

/home/runner/work/repo/file.ts
    55:5  warning  Unexpected 'todo' comment: 'TODO: Add test for this eventuality:...'     no-warning-comments

Problem not matched:

  /home/runner/work/repo/file.ts
    14:1  error  'webext-messenger' should be listed in the project's dependencies. Run 'npm i -S webext-messenger' to add it  import/no-extraneous-dependencies
@fregante fregante added bug Something isn't working needs triage labels Mar 9, 2025
@fregante fregante linked a pull request Mar 9, 2025 that will close this issue
2 tasks
@mahabaleshwars
Copy link

Hi @fregante,
Thank you for creating this issue. We will investigate it and provide feedback as soon as we have some updates.

@priya-kinthali priya-kinthali self-assigned this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants