fix(sql_workbench): fix MongoDB datasource sync for ODC

Remove MongoDB from SupportDBType so datasources are retained without
provision accounts. Map connection params to jdbcUrlParameters that ODC
actually reads instead of unused properties, and add TLS-only test.

Author: LordofAvernus

internal/sql_workbench/service/sql_workbench_service.go

@@ -985,8 +985,7 @@ func (sqlWorkbenchService *SqlWorkbenchService) SupportDBType(dbType pkgConst.DB
 		dbType == pkgConst.DBTypeTiDB ||
 		dbType == pkgConst.DBTypeTDSQLForInnoDB ||
 		dbType == pkgConst.DBTypeGoldenDB ||
-		dbType == pkgConst.DBTypePolarDBForMySQL ||
-		dbType == pkgConst.DBTypeMongoDB
+		dbType == pkgConst.DBTypePolarDBForMySQL
 }
 
 func buildMongoDatasourceOptions(dbService *biz.DBService) (*string, interface{}, map[string]interface{}) {
@@ -996,35 +995,34 @@ func buildMongoDatasourceOptions(dbService *biz.DBService) (*string, interface{}
 		defaultSchema = &defaultDatabase
 	}
 
-	properties := map[string]interface{}{}
-	if defaultDatabase != "" {
-		properties["defaultDatabase"] = defaultDatabase
-	}
+	jdbcParams := map[string]interface{}{}
 	if authDB := dbService.AdditionalParams.GetParam(mongoAuthDatabaseParam).String(); authDB != "" {
-		properties["authenticationDatabase"] = authDB
+		jdbcParams["authSource"] = authDB
 	}
 	if authMechanism := dbService.AdditionalParams.GetParam(mongoAuthMechanismParam).String(); authMechanism != "" {
-		properties["authMechanism"] = authMechanism
+		jdbcParams["authMechanism"] = authMechanism
 	}
 	if replicaSet := dbService.AdditionalParams.GetParam(mongoReplicaSetParam).String(); replicaSet != "" {
-		properties["replicaSet"] = replicaSet
+		jdbcParams["replicaSet"] = replicaSet
 	}
-	if len(properties) > 0 {
-		properties["tlsEnabled"] = dbService.AdditionalParams.GetParam(mongoTLSEnabledParam).Bool()
+	if tlsParam := dbService.AdditionalParams.GetParam(mongoTLSEnabledParam); tlsParam != nil && tlsParam.String() != "" {
+		if tlsParam.Bool() {
+			jdbcParams["tls"] = "true"
+		} else {
+			jdbcParams["tls"] = "false"
+		}
 	}
-
-	jdbcParams := map[string]interface{}{}
 	if dbService.AdditionalParams.GetParam(mongoDirectConnectionParam).Bool() {
 		jdbcParams["directConnection"] = true
 	}
 	if dbService.AdditionalParams.GetParam(mongoTLSSkipVerifyParam).Bool() {
 		jdbcParams["tlsInsecure"] = true
 	}
 
-	if len(properties) == 0 {
-		return defaultSchema, nil, jdbcParams
+	if len(jdbcParams) == 0 {
+		return defaultSchema, nil, nil
 	}
-	return defaultSchema, properties, jdbcParams
+	return defaultSchema, nil, jdbcParams
 }
 
 func interfacePtr(v interface{}) *interface{} {

internal/sql_workbench/service/sql_workbench_service_test.go

@@ -51,7 +51,7 @@ func Test_SupportDBType(t *testing.T) {
 		"TiDB supported":              {input: pkgConst.DBTypeTiDB, expected: true},
 		"TDSQL supported":             {input: pkgConst.DBTypeTDSQLForInnoDB, expected: true},
 		"GoldenDB supported":          {input: pkgConst.DBTypeGoldenDB, expected: true},
-		"MongoDB supported":           {input: pkgConst.DBTypeMongoDB, expected: true},
+		"MongoDB unsupported":         {input: pkgConst.DBTypeMongoDB, expected: false},
 		"PostgreSQL unsupported":      {input: pkgConst.DBTypePostgreSQL, expected: false},
 		"SQL Server unsupported":      {input: pkgConst.DBTypeSQLServer, expected: false},
 		"PolarDB For MySQL supported": {input: pkgConst.DBTypePolarDBForMySQL, expected: true},
@@ -85,18 +85,38 @@ func Test_buildMongoDatasourceOptions(t *testing.T) {
 	if defaultSchema == nil || *defaultSchema != defaultDB {
 		t.Fatalf("unexpected default schema: %#v", defaultSchema)
 	}
-	properties, ok := propertiesValue.(map[string]interface{})
-	if !ok {
-		t.Fatalf("unexpected properties type: %T", propertiesValue)
+	if propertiesValue != nil {
+		t.Fatalf("expected nil properties, got %#v", propertiesValue)
 	}
-	if properties["authenticationDatabase"] != "admin" {
-		t.Fatalf("unexpected auth db: %#v", properties)
+	if jdbcParams["authSource"] != "admin" {
+		t.Fatalf("unexpected authSource: %#v", jdbcParams["authSource"])
 	}
-	if properties["tlsEnabled"] != true {
-		t.Fatalf("unexpected tlsEnabled: %#v", properties)
+	if jdbcParams["authMechanism"] != "SCRAM-SHA-256" {
+		t.Fatalf("unexpected authMechanism: %#v", jdbcParams["authMechanism"])
+	}
+	if jdbcParams["replicaSet"] != "rs0" {
+		t.Fatalf("unexpected replicaSet: %#v", jdbcParams["replicaSet"])
+	}
+	if jdbcParams["tls"] != "true" {
+		t.Fatalf("unexpected tls: %#v", jdbcParams["tls"])
 	}
 	if jdbcParams["directConnection"] != true || jdbcParams["tlsInsecure"] != true {
 		t.Fatalf("unexpected jdbc params: %#v", jdbcParams)
 	}
 }
 
+func Test_buildMongoDatasourceOptions_tlsOnly(t *testing.T) {
+	_, propertiesValue, jdbcParams := buildMongoDatasourceOptions(&biz.DBService{
+		DBType: string(pkgConst.DBTypeMongoDB),
+		AdditionalParams: pkgParams.Params{
+			&pkgParams.Param{Key: mongoTLSEnabledParam, Value: "true", Type: pkgParams.ParamTypeBool},
+		},
+	})
+	if propertiesValue != nil {
+		t.Fatalf("expected nil properties, got %#v", propertiesValue)
+	}
+	if jdbcParams["tls"] != "true" {
+		t.Fatalf("expected tls in jdbcUrlParameters when only tls is configured, got %#v", jdbcParams)
+	}
+}
+