[Bug]: In/Out column cannot be selected

[Gmanicus]

Verified issue does not already exist?

• I have searched and found no existing issue

What happened?

When importing transactions from a CSV, I appear to be unable to specify which column determines whether the amount is in/outflow.

I see "In/Out" in the preview, but no option to select which column has the value.

How can we reproduce the issue?

1. Import CSV with "Split into separate inflow outflow columns" enabled
2. Import CSV again, but disable split mode
3. Check "Select column to specify if amount goes in/out"
   In-Out-Example.csv

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome, Other

Operating System

Windows 10

[youngcw]

Have you typed in the column to use in the field next to the checkbox?

[Gmanicus]

I believe so. Let me double-check. Yes. The column name is "Credit or Debit". Entering that doesn't update the preview with the correct in/out flows. If I understand correctly, I think that text box is for determining which value within the column is "positive" and by exclusion which is "negative" as well.

[youngcw]

Seems just fine to me

[Gmanicus]

Huh. Something's odd on my end. When I check "Select in/out column", it auto-checks "Split amount into separate inflow/outflow columns" and locks me out of disabling them. Now I can't change either option even if I exit out of the modal. If I come back, they're still checked 👀

I wonder if this is a bug caused by having an account that already has inflow and outflow columns and saved transactions.

[Gmanicus]

Tried setting up a dev environment but couldn't get it started up. Will probably take another crack at it tomorrow to see if I can take a peek at the code. Thanks for taking a look and troubleshooting with me 🙏

[MatissJanis]

@Gmanicus how's this looking? All good?

I'd like to close the issue if all good.

[Gmanicus]

Hey @MatissJanis, sorry for the delay on this. Got busy over the last few weeks and never got back to this.

Still stuck, unfortunately. Going to get back on that dev environment right now and will report back.

EDIT: Finally figured out what was going wrong and got the dev container up. I'll start poking around.

[Gmanicus]

I wonder if this is a bug caused by having an account that already has inflow and outflow columns and saved transactions.

I think I was spot on here.

When the In/Out status is changed, it reloads the preview. This then reloads the transactions, as well as the Split amount status. Split amount appears to be enabled if either the Inflow or Outflow columns have values.

Additionally, In/Out appears to be designed to be used in replacement of Split amount. So, if In/Out is enabled, Split amount is disabled, and vice versa.

Due to my configuration, I have a bit of a catch 22 situation. My transactions already have Inflow/Outflow columns, so Split amount is enabled. My configuration has also saved In/Out as enabled since I tried to set it previously. So, both are enabled, making me unable to disable either of them.

If I work around this by changing the disabled condition, Split amount still remains checked since I already have Inflow/Outflow columns, making me unable to set up In/Out. How I got there in the first place, I do not know.

I have some plan of how to fix this:

1. The In/Out behavior should work with Split amount, not against it, and change how the transaction value is saved accordingly.