Skip to content

Commit 7777411

Browse files
author
MarcoFalke
committed
Remove __cplusplus from compat/assumptions.h
It is unclear what the goal of this check is, given that the value may need to be set lower for the mimimum supported version of compilers that forgot to bump the value, see bitcoin#28349 (comment) . The minimum supported compiler versions are already documented in doc/dependencies.md and using an older compiler will already result in a compile failure, so this check can be removed as redundant. Especially given that it is only included in one file, where iwyu suggests to remove it.
1 parent faa3d4f commit 7777411

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/compat/assumptions.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,6 @@
1111
#include <cstddef>
1212
#include <limits>
1313

14-
// Assumption: We assume a C++17 (ISO/IEC 14882:2017) compiler (minimum requirement).
15-
// Example(s): We assume the presence of C++17 features everywhere :-)
16-
// ISO Standard C++17 [cpp.predefined]p1:
17-
// "The name __cplusplus is defined to the value 201703L when compiling a C++
18-
// translation unit."
19-
static_assert(__cplusplus >= 201703L, "C++17 standard assumed");
20-
2114
// Assumption: We assume the floating-point types to fulfill the requirements of
2215
// IEC 559 (IEEE 754) standard.
2316
// Example(s): Floating-point division by zero in ConnectBlock, CreateTransaction

0 commit comments

Comments
 (0)