change strict klib validation so it's not configurable per target, but per project

Author: aSemy

modules/bcv-gradle-plugin/api/bcv-gradle-plugin.api

@@ -1,3 +1,8 @@
+public abstract class dev/adamko/kotlin/binary_compatibility_validator/BCVKLibConventions : dev/adamko/kotlin/binary_compatibility_validator/targets/KLibValidationSpec {
+	public fun <init> ()V
+	public abstract fun getStrictValidation ()Lorg/gradle/api/provider/Property;
+}
+
 public abstract class dev/adamko/kotlin/binary_compatibility_validator/BCVPlugin : org/gradle/api/Plugin {
 	public static final field API_CHECK_TASK_NAME Ljava/lang/String;
 	public static final field API_DIR Ljava/lang/String;
@@ -158,6 +163,7 @@ public abstract class dev/adamko/kotlin/binary_compatibility_validator/tasks/BCV
 	public abstract fun getOutputApiBuildDir ()Lorg/gradle/api/file/DirectoryProperty;
 	public abstract fun getProjectName ()Lorg/gradle/api/provider/Property;
 	public abstract fun getRuntimeClasspath ()Lorg/gradle/api/file/ConfigurableFileCollection;
+	public abstract fun getStrictKLibTargetValidation ()Lorg/gradle/api/provider/Property;
 	public final fun getTargets ()Lorg/gradle/api/NamedDomainObjectContainer;
 }
 

modules/bcv-gradle-plugin/src/main/kotlin/BCVKLibConventions.kt

@@ -0,0 +1,17 @@
+package dev.adamko.kotlin.binary_compatibility_validator
+
+import dev.adamko.kotlin.binary_compatibility_validator.internal.BCVExperimentalApi
+import dev.adamko.kotlin.binary_compatibility_validator.targets.KLibValidationSpec
+import org.gradle.api.provider.Property
+
+@OptIn(BCVExperimentalApi::class)
+abstract class BCVKLibConventions : KLibValidationSpec {
+
+  /**
+   * Fail validation if some build targets are not supported by the host compiler.
+   *
+   * By default, ABI dumped only for supported files will be validated. This option makes
+   * validation behavior stricter and treats having unsupported targets as an error.
+   */
+  abstract val strictValidation: Property<Boolean>
+}

modules/bcv-gradle-plugin/src/main/kotlin/BCVProjectExtension.kt

@@ -3,7 +3,6 @@ package dev.adamko.kotlin.binary_compatibility_validator
 import dev.adamko.kotlin.binary_compatibility_validator.internal.*
 import dev.adamko.kotlin.binary_compatibility_validator.targets.BCVTarget
 import dev.adamko.kotlin.binary_compatibility_validator.targets.BCVTargetBaseSpec
-import dev.adamko.kotlin.binary_compatibility_validator.targets.KLibValidationSpec
 import javax.inject.Inject
 import org.gradle.api.file.DirectoryProperty
 import org.gradle.api.model.ObjectFactory
@@ -46,9 +45,9 @@ constructor(
   abstract override val ignoredClasses: SetProperty<String>
 
   @BCVExperimentalApi
-  val klib: KLibValidationSpec =
+  val klib: BCVKLibConventions =
     extensions.adding("klib") {
-      objects.newInstance(KLibValidationSpec::class)
+      objects.newInstance(BCVKLibConventions::class)
     }
 
   /**

modules/bcv-gradle-plugin/src/main/kotlin/BCVProjectPlugin.kt

@@ -100,7 +100,7 @@ constructor(
         enabled.convention(extension.klib.enabled)
 
         signatureVersion.convention(extension.klib.signatureVersion)
-        strictValidation.convention(extension.klib.strictValidation)
+//        strictValidation.convention(extension.klib.strictValidation)
         supportedByCurrentHost.convention(false)
       }
 
@@ -179,6 +179,9 @@ constructor(
       outputApiBuildDir.convention(layout.buildDirectory.dir("bcv-api"))
       projectName.convention(extension.projectName)
 
+      @OptIn(BCVExperimentalApi::class)
+      strictKLibTargetValidation.convention(extension.klib.strictValidation)
+
       onlyIf("Must have at least one target") { targets.isNotEmpty() }
     }
 

modules/bcv-gradle-plugin/src/main/kotlin/targets/BCVTargetDefaults.kt

@@ -1,5 +1,6 @@
 package dev.adamko.kotlin.binary_compatibility_validator.targets
 
+import dev.adamko.kotlin.binary_compatibility_validator.BCVKLibConventions
 import dev.adamko.kotlin.binary_compatibility_validator.internal.BCVExperimentalApi
 import dev.adamko.kotlin.binary_compatibility_validator.internal.BCVInternalApi
 import dev.adamko.kotlin.binary_compatibility_validator.internal.adding
@@ -43,8 +44,8 @@ constructor(
   abstract override val ignoredClasses: SetProperty<String>
 
   @BCVExperimentalApi
-  val klib: KLibValidationSpec =
+  val klib: BCVKLibConventions =
     extensions.adding("klib") {
-      objects.newInstance(KLibValidationSpec::class)
+      objects.newInstance(BCVKLibConventions::class)
     }
 }

modules/bcv-gradle-plugin/src/main/kotlin/targets/KLibValidationSpec.kt

@@ -42,14 +42,4 @@ interface KLibValidationSpec {
    */
   fun signatureVersion(version: Int): Unit =
     signatureVersion.set(KLibSignatureVersion.of(version))
-
-  /**
-   * Fail validation if some build targets are not supported by the host compiler.
-   *
-   * By default, ABI dumped only for supported files will be validated. This option makes
-   * validation behavior stricter and treats having unsupported targets as an error.
-   */
-  @get:Input
-  @get:Optional
-  val strictValidation: Property<Boolean>
 }

modules/bcv-gradle-plugin/src/main/kotlin/tasks/BCVApiGenerateTask.kt

@@ -44,6 +44,9 @@ constructor(
   @get:Input
   abstract val projectName: Property<String>
 
+  @get:Input
+  abstract val strictKLibTargetValidation: Property<Boolean>
+
   /**
    * A directory containing a copy of any currently existing API Dump files.
    * Provided by [BCVApiGeneratePreparationTask].