Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for localized strings #64

Closed
cquike opened this issue Oct 12, 2021 · 3 comments
Closed

Add support for localized strings #64

cquike opened this issue Oct 12, 2021 · 3 comments

Comments

@cquike
Copy link

cquike commented Oct 12, 2021

This library output some strings to the console that are hardcoded in English and cannot be localized. It would be nice if these strings could be translated to other languages using for instance something like gettext.
Examples of those strings are:

  • Description of default options ("Show help", "Show version", "Verbosity level") in file Command.php
  • Help messages ("Comand ... version", "Usage:", "Legend...") in Command.php
  • Error messages like 'Invalid value. Please try again!' in Interactor.php
@adhocore
Copy link
Owner

yea thanks. in general i am okay with that but i think it is not very important. also i don't know many languages out there.
with that said, if you could send a PR for fixing it in the simplest way possible, then that would be great

@adhocore
Copy link
Owner

adhocore commented Dec 4, 2024

fixed in #120

@adhocore adhocore closed this as completed Dec 4, 2024
@cquike
Copy link
Author

cquike commented Dec 4, 2024

Thank you for adding this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants