Merge pull request #19 from martijnengler/18-throw-from-parse-from-file

Author: adhocore

src/Comment.php

@@ -204,6 +204,10 @@ public static function parse(string $json, bool $assoc = false, int $depth = 512
 
     public static function parseFromFile(string $file, bool $assoc = false, int $depth = 512, int $options = 0)
     {
+        if (!is_file($file)) {
+            throw new \InvalidArgumentException($file . ' does not exist or is not a file');
+        }
+
         $json = \file_get_contents($file);
 
         return static::parse(\trim($json), $assoc, $depth, $options);

tests/CommentTest.php

@@ -68,6 +68,24 @@ public function testParseFromFile()
         $this->assertSame('adhocore/json-comment', $parsed['name']);
     }
 
+    public function testParseFromFileThrowsNotExists()
+    {
+        $file = 'does-not-exist.json';
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage($file . ' does not exist or is not a file');
+
+        Comment::parseFromFile($file, true);
+    }
+
+    public function testParseFromFileThrowsNotFile()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage(__DIR__ . ' does not exist or is not a file');
+
+        Comment::parseFromFile(__DIR__, true);
+    }
+
     public function testSubJson()
     {
         // https://github.com/adhocore/php-json-comment/issues/15